[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotat
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations |
Date: |
Mon, 8 Jul 2019 14:54:32 +0200 |
According to the comment, the bits are supposed to accumulate.
Reported-by: Stefan Weil <address@hidden>
Fixes: 5d1abf234462 ("s390x/pci: enforce zPCI state checking")
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/s390-pci-inst.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index 61f30b8e55d2..00235148bed7 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -1209,8 +1209,10 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1,
uint64_t fiba, uint8_t ar,
* FH Enabled bit is set to one in states of ENABLED, BLOCKED or ERROR. */
case ZPCI_FS_ERROR:
fib.fc |= 0x20;
+ /* fallthrough */
case ZPCI_FS_BLOCKED:
fib.fc |= 0x40;
+ /* fallthrough */
case ZPCI_FS_ENABLED:
fib.fc |= 0x80;
if (pbdev->iommu->enabled) {
--
2.20.1
- [Qemu-devel] [PATCH for-4.1 0/2] s390x: fallthrough annotations, Cornelia Huck, 2019/07/08
- [Qemu-devel] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations,
Cornelia Huck <=
- Re: [Qemu-devel] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Christian Borntraeger, 2019/07/08
- Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Collin Walling, 2019/07/09
- Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Cornelia Huck, 2019/07/10
- Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Cornelia Huck, 2019/07/16
- Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Collin Walling, 2019/07/16
- Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Cornelia Huck, 2019/07/17
- Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Christian Borntraeger, 2019/07/17
- Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Collin Walling, 2019/07/17
- Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations, Cornelia Huck, 2019/07/18
[Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotation, Cornelia Huck, 2019/07/08