[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support |
Date: |
Tue, 16 Jul 2019 08:04:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 7/16/19 2:18 PM, Peter Maydell wrote:
> On Tue, 16 Jul 2019 at 15:02, Richard Henderson
> <address@hidden> wrote:
>>
>> On 7/16/19 12:03 PM, Peter Maydell wrote:
>>> The intention of the assertion really is to catch QEMU bugs
>>> where we got the ID register values wrong in our emulated
>>> CPUs. Perhaps we should relax all these assertions to only
>>> testing if we're using TCG, not KVM ?
>>
>> Perhaps. In some instances if ID register values are wrong we would then not
>> migrate properly, but none of the checks we're currently doing of this sort
>> would catch those particular cases.
>
> In those cases we should probably print a warning and install
> a migration-blocker, rather than asserting...
Ok, but I'm saying we don't assert for those either, at the moment.
r~
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Peter Maydell, 2019/07/16
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Richard Henderson, 2019/07/16
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Laszlo Ersek, 2019/07/16
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Peter Maydell, 2019/07/16
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Laszlo Ersek, 2019/07/16
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Philippe Mathieu-Daudé, 2019/07/16
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Laszlo Ersek, 2019/07/17
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Laszlo Ersek, 2019/07/17
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Laszlo Ersek, 2019/07/17
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Laszlo Ersek, 2019/07/17
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Laszlo Ersek, 2019/07/17
- Re: [Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support, Philippe Mathieu-Daudé, 2019/07/17