[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes
Date: Wed, 10 Jul 2019 16:40:05 +0100

On Wed, 10 Jul 2019 at 10:22, Aleksandar Markovic
<address@hidden> wrote:
> The commit message looks more like a list of some random items
> than logical explanation of the code change. Improve it.

Can you be less combative in your review comments, please?
Providing constructive and specific suggestions for the
improvements you'd like to see is more likely to help
us produce better software than abrupt orders to "improve it".

This is about the third or fourth time you've done this
with RTH's patches and I think it is not really warranted.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]