qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction


From: Bastian Koppelmann
Subject: Re: [Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction
Date: Tue, 25 Jun 2019 12:03:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1


On 6/24/19 9:03 AM, David Brenken wrote:
+
+        result = 0;
+        result = deposit32(result, 31, 1, new_S);
+        result = deposit32(result, 23, 8, new_E);
+        result = deposit32(result, 15, 8, new_M);
+    }
+
+    if (float32_is_signaling_nan(arg1) || result == float32_sqrt_nan) {

float32_is_signaling_nan needs fp_status as an argument. I'll fix it for you this 
time, but please check if each patch builds before submitting them. Otherwise: 
Reviewed-by: Bastian Koppelmann <address@hidden>

Cheers,
Bastian




reply via email to

[Prev in Thread] Current Thread [Next in Thread]