Re: [Qemu-devel] [PATCH v2 15/15] target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro

[Richard Henderson]

On 6/2/19 4:09 AM, Mark Cave-Ayland wrote:
> Introduce a new GEN_VSX_HELPER_VSX_MADD macro for the generator function which
> enables the source and destination registers to be decoded at translation 
> time.
> 
> This enables the determination of a or m form to be made at translation time 
> so
> that a single helper function can now be used for both variants.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  target/ppc/fpu_helper.c             | 68 ++++++++++---------------------
>  target/ppc/helper.h                 | 48 ++++++++--------------
>  target/ppc/translate/vsx-impl.inc.c | 81 
> +++++++++++++++++++++----------------
>  target/ppc/translate/vsx-ops.inc.c  | 70 +++++++++++++++++---------------
>  4 files changed, 122 insertions(+), 145 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~