Re: [Qemu-devel] [PATCH v2 11/15] target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c

[Richard Henderson]

On 6/2/19 4:08 AM, Mark Cave-Ayland wrote:
> Rather than perform the VSR register decoding within the helper itself,
> introduce a new GEN_VSX_HELPER_R2 macro which performs the decode based
> upon rD and rB at translation time.
> 
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
>  target/ppc/fpu_helper.c             | 30 ++++++++++++-----------------
>  target/ppc/helper.h                 | 20 +++++++++----------
>  target/ppc/translate/vsx-impl.inc.c | 38 
> +++++++++++++++++++++++++++----------
>  3 files changed, 50 insertions(+), 38 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~