[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces for io_uring |
Date: |
Wed, 12 Jun 2019 15:43:40 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Tue, Jun 11, 2019 at 07:17:14PM +0800, Fam Zheng wrote:
> On Mon, 06/10 19:18, Aarushi Mehta wrote:
> > + /* Prevent infinite loop if submission is refused */
> > + if (ret <= 0) {
> > + if (ret == -EAGAIN) {
> > + continue;
> > + }
> > + break;
> > + }
> > + s->io_q.in_flight += ret;
> > + s->io_q.in_queue -= ret;
> > + }
> > + s->io_q.blocked = (s->io_q.in_queue > 0);
>
> I'm confused about s->io_q.blocked. ioq_submit is where it gets updated, but
> if it becomes true, calling ioq_submit will be fenced. So how does it get
> cleared?
When blocked, additional I/O requests are not submitted until the next
completion. See qemu_luring_process_completions_and_submit() for the
code path where ioq_submit() gets called again.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v5 01/12] configure: permit use of io_uring, (continued)
- [Qemu-devel] [PATCH v5 01/12] configure: permit use of io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 02/12] qapi/block-core: add option for io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 03/12] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 05/12] stubs: add stubs for io_uring interface, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 06/12] util/async: add aio interfaces for io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 08/12] block/file-posix.c: extend to use io_uring, Aarushi Mehta, 2019/06/10
- [Qemu-devel] [PATCH v5 07/12] blockdev: accept io_uring as option, Aarushi Mehta, 2019/06/10