[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] target/rx: Use prt_ldmi for XCHG_mr disasse
From: |
Yoshinori Sato |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] target/rx: Use prt_ldmi for XCHG_mr disassembly |
Date: |
Tue, 28 May 2019 00:30:16 +0900 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
On Fri, 24 May 2019 00:08:00 +0900,
Richard Henderson wrote:
>
> Note that the ld == 3 case handled by prt_ldmi is decoded as
> XCHG_rr and cannot appear here.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Yoshinori Sato <address@hidden>
> ---
> target/rx/disas.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/target/rx/disas.c b/target/rx/disas.c
> index 515b365528..db10385fd0 100644
> --- a/target/rx/disas.c
> +++ b/target/rx/disas.c
> @@ -366,13 +366,7 @@ static bool trans_XCHG_rr(DisasContext *ctx, arg_XCHG_rr
> *a)
> /* xchg dsp[rs].<mi>,rd */
> static bool trans_XCHG_mr(DisasContext *ctx, arg_XCHG_mr *a)
> {
> - static const char msize[][4] = {
> - "b", "w", "l", "ub", "uw",
> - };
> - char dsp[8];
> -
> - rx_index_addr(ctx, dsp, a->ld, a->mi);
> - prt("xchg\t%s[r%d].%s, r%d", dsp, a->rs, msize[a->mi], a->rd);
> + prt_ldmi(ctx, "xchg", a->ld, a->mi, a->rs, a->rd);
> return true;
> }
>
> --
> 2.17.1
>
- [Qemu-devel] [PATCH 0/6] target/rx: Improvements to disassembly, Richard Henderson, 2019/05/23
- [Qemu-devel] [PATCH 1/6] target/rx: Disassemble rx_index_addr into a string, Richard Henderson, 2019/05/23
- [Qemu-devel] [PATCH 2/6] target/rx: Replace operand with prt_ldmi in disassembler, Richard Henderson, 2019/05/23
- [Qemu-devel] [PATCH 5/6] target/rx: Collect all bytes during disassembly, Richard Henderson, 2019/05/23
- [Qemu-devel] [PATCH 3/6] target/rx: Use prt_ldmi for XCHG_mr disassembly, Richard Henderson, 2019/05/23
- Re: [Qemu-devel] [PATCH 3/6] target/rx: Use prt_ldmi for XCHG_mr disassembly,
Yoshinori Sato <=
- [Qemu-devel] [PATCH 6/6] target/rx: Dump bytes for each insn during disassembly, Richard Henderson, 2019/05/23
- [Qemu-devel] [PATCH 4/6] target/rx: Emit all disassembly in one prt(), Richard Henderson, 2019/05/23
- Re: [Qemu-devel] [PATCH 0/6] target/rx: Improvements to disassembly, Yoshinori Sato, 2019/05/27