Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard

[Wei Yang]

On Tue, May 21, 2019 at 05:28:27PM +0200, Markus Armbruster wrote:
>Eric Blake <address@hidden> writes:
>
>> On 5/21/19 3:12 AM, Wei Yang wrote:
>>> All the python script in scripts/qapi is used to generate qapi code. Use
>>> wildcard to simplify it.
>>> 
>>> Signed-off-by: Wei Yang <address@hidden>
>>> ---
>>>  Makefile | 8 +-------
>>>  1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> I'm not a fan of $(wildcard). It makes your tarball creation
>> non-deterministic - if there is a leftover file from development that is
>> no longer part of the build, wildcard will still pick it up.  Explicit
>
>Actually, in this case can "only" adds spurious prerequisites.

Hmm... which spurious prerequisites will be added? I may miss something here.

>
>> lists are better.  I'm inclined to NACK this, but Markus has final say
>> since he maintains the qapi generator.
>
>I consider use of $(wildcard) for the purpose of collecting sources a
>lazy mistake.

-- 
Wei Yang
Help you, Help me