[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wild
Re: [Qemu-devel] [PATCH] Makefile: simplify qapi-py definition with wildcard
Wed, 22 May 2019 08:52:20 +0800
On Tue, May 21, 2019 at 07:00:12AM -0500, Eric Blake wrote:
>On 5/21/19 3:12 AM, Wei Yang wrote:
>> All the python script in scripts/qapi is used to generate qapi code. Use
>> wildcard to simplify it.
>> Signed-off-by: Wei Yang <address@hidden>
>> Makefile | 8 +-------
>> 1 file changed, 1 insertion(+), 7 deletions(-)
>I'm not a fan of $(wildcard). It makes your tarball creation
>non-deterministic - if there is a leftover file from development that is
>no longer part of the build, wildcard will still pick it up. Explicit
>lists are better. I'm inclined to NACK this, but Markus has final say
>since he maintains the qapi generator.
Thanks for comment.
Yes, for tarball, the order is a problem. But those python scripts are not
used in tarballs.
For leftover files, you mean those files not used and should be deleted?
Help you, Help me