[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvn
From: |
Mark Cave-Ayland |
Subject: |
Re: [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p |
Date: |
Fri, 10 May 2019 16:02:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 09/05/2019 01:49, Anton Blanchard wrote:
> We were using set_cpu_vsr*() when we should have used get_cpu_vsr*().
>
> Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}()
> helpers for VSR register access")
> Signed-off-by: Anton Blanchard <address@hidden>
> ---
> target/ppc/translate/vsx-impl.inc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/translate/vsx-impl.inc.c
> b/target/ppc/translate/vsx-impl.inc.c
> index b487136d52..4b7627f53b 100644
> --- a/target/ppc/translate/vsx-impl.inc.c
> +++ b/target/ppc/translate/vsx-impl.inc.c
> @@ -859,8 +859,8 @@ static void glue(gen_, name)(DisasContext *ctx)
> \
> xbh = tcg_temp_new_i64(); \
> xbl = tcg_temp_new_i64(); \
> sgm = tcg_temp_new_i64(); \
> - set_cpu_vsrh(xB(ctx->opcode), xbh); \
> - set_cpu_vsrl(xB(ctx->opcode), xbl); \
> + get_cpu_vsrh(xbh, xB(ctx->opcode)); \
> + get_cpu_vsrl(xbl, xB(ctx->opcode)); \
> tcg_gen_movi_i64(sgm, sgn_mask); \
> switch (op) { \
> case OP_ABS: { \
Reviewed-by: Mark Cave-Ayland <address@hidden>
ATB,
Mark.
- [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Anton Blanchard, 2019/05/06
- [Qemu-devel] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Anton Blanchard, 2019/05/06
- Re: [Qemu-devel] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, David Gibson, 2019/05/07
- [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Anton Blanchard, 2019/05/08
- Re: [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p,
Mark Cave-Ayland <=
- Re: [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, David Gibson, 2019/05/13
- Re: [Qemu-devel] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Mark Cave-Ayland, 2019/05/07
[Qemu-devel] [PATCH 2/9] target/ppc: Fix xxspltib, Anton Blanchard, 2019/05/06
[Qemu-devel] [PATCH 3/9] target/ppc: Fix xxbrq, xxbrw, Anton Blanchard, 2019/05/06
[Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x, Anton Blanchard, 2019/05/06