[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 14/24] linux-user: Use qemu_guest_getrandom_nofai
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v5 14/24] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM |
Date: |
Thu, 9 May 2019 18:24:48 -0700 |
Use a better interface for random numbers than rand * 16.
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
linux-user/elfload.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index c1a26021f8..e673f7ea55 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -7,6 +7,7 @@
#include "qemu.h"
#include "disas/disas.h"
#include "qemu/path.h"
+#include "qemu/guest-random.h"
#ifdef _ARCH_PPC64
#undef ARCH_DLINFO
@@ -1883,12 +1884,9 @@ static abi_ulong create_elf_tables(abi_ulong p, int
argc, int envc,
}
/*
- * Generate 16 random bytes for userspace PRNG seeding (not
- * cryptically secure but it's not the aim of QEMU).
+ * Generate 16 random bytes for userspace PRNG seeding.
*/
- for (i = 0; i < 16; i++) {
- k_rand_bytes[i] = rand();
- }
+ qemu_guest_getrandom_nofail(k_rand_bytes, sizeof(k_rand_bytes));
if (STACK_GROWS_DOWN) {
sp -= 16;
u_rand_bytes = sp;
--
2.17.1
- [Qemu-devel] [PATCH v5 12/24] linux-user: Initialize pseudo-random seeds for all guest cpus, (continued)
- [Qemu-devel] [PATCH v5 12/24] linux-user: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 03/24] crypto: Reverse code blocks in random-platform.c, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 11/24] cpus: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 18/24] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 05/24] crypto: Use O_CLOEXEC in qcrypto_random_init, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 02/24] crypto: Merge crypto-obj-y into libqemuutil.a, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 14/24] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM,
Richard Henderson <=
- [Qemu-devel] [PATCH v5 09/24] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 13/24] linux-user: Call qcrypto_init if not using -seed, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 07/24] crypto: Change the qcrypto_random_bytes buffer type to void*, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 08/24] ui/vnc: Split out authentication_failed, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 10/24] util: Add qemu_guest_getrandom and associated routines, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 15/24] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 16/24] linux-user: Remove srand call, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 17/24] aspeed/scu: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/09