[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 18/24] hw/misc/nrf51_rng: Use qemu_guest_getrando
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v5 18/24] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail |
Date: |
Thu, 9 May 2019 18:24:52 -0700 |
The random number is intended for use by the guest. As such, we should
honor the -seed argument for reproducibility. Use the *_nofail routine
instead of error_abort directly.
Cc: address@hidden
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Joel Stanley <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
hw/misc/nrf51_rng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/misc/nrf51_rng.c b/hw/misc/nrf51_rng.c
index d188f044f4..3400e90a9b 100644
--- a/hw/misc/nrf51_rng.c
+++ b/hw/misc/nrf51_rng.c
@@ -14,7 +14,7 @@
#include "qapi/error.h"
#include "hw/arm/nrf51.h"
#include "hw/misc/nrf51_rng.h"
-#include "crypto/random.h"
+#include "qemu/guest-random.h"
static void update_irq(NRF51RNGState *s)
{
@@ -145,7 +145,7 @@ static void nrf51_rng_timer_expire(void *opaque)
{
NRF51RNGState *s = NRF51_RNG(opaque);
- qcrypto_random_bytes(&s->value, 1, &error_abort);
+ qemu_guest_getrandom_nofail(&s->value, 1);
s->event_valrdy = 1;
qemu_set_irq(s->eep_valrdy, 1);
--
2.17.1
- [Qemu-devel] [PATCH v5 00/24] Add qemu_getrandom and ARMv8.5-RNG etc, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 06/24] crypto: Use getrandom for qcrypto_random_bytes, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 01/24] configure: Link test before auto-enabling crypto libraries, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 04/24] crypto: Do not fail for EINTR during qcrypto_random_bytes, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 12/24] linux-user: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 03/24] crypto: Reverse code blocks in random-platform.c, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 11/24] cpus: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 18/24] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail,
Richard Henderson <=
- [Qemu-devel] [PATCH v5 05/24] crypto: Use O_CLOEXEC in qcrypto_random_init, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 02/24] crypto: Merge crypto-obj-y into libqemuutil.a, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 14/24] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 09/24] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 13/24] linux-user: Call qcrypto_init if not using -seed, Richard Henderson, 2019/05/09
- [Qemu-devel] [PATCH v5 07/24] crypto: Change the qcrypto_random_bytes buffer type to void*, Richard Henderson, 2019/05/09