|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu |
| Date: | Wed, 8 May 2019 07:32:58 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/8/19 1:15 AM, Aleksandar Markovic wrote: > > On May 8, 2019 2:19 AM, "Richard Henderson" <address@hidden > <mailto:address@hidden>> wrote: >> >> >> > > This commit message doesnˊt explain the reason for the change, and why is this > an improvement. The underlyng reason for distingishing between env_cpu and > env_archcpu cases is not explained too. It's certainly explained in the preceeding patches that introduce those functions. Are you suggesting that it is beneficial to copy-and-paste a common block explanation into 21 commit messages for each of target/foo/? r~
| [Prev in Thread] | Current Thread | [Next in Thread] |