[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu

From: Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH v3 18/39] target/mips: Use env_cpu, env_archcpu
Date: Thu, 16 May 2019 08:29:55 +0200

On May 8, 2019 4:33 PM, "Richard Henderson" <address@hidden>
> On 5/8/19 1:15 AM, Aleksandar Markovic wrote:
> >
> > On May 8, 2019 2:19 AM, "Richard Henderson" <
> > <mailto:address@hidden>> wrote:
> >>
> >>
> >>
> >
> > This commit message doesnˊt explain the reason for the change, and why
is this
> > an improvement. The underlyng reason for distingishing between  env_cpu
> > env_archcpu cases is not explained too.
> It's certainly explained in the preceeding patches that introduce those
> Are you suggesting that it is beneficial to copy-and-paste a common block
> explanation into 21 commit messages for each of target/foo/?

My objection, as I am the maintainer for MIPS part, is about this very

If you can't put together a classical standalone commit message which will
be according to our guidelines for writing a good commit message, the
minimum I expect from you is the following commit message:

“Please refer to the commit message(s) for commit(s) <here you list the
titles of the commits that contain explanation for this commit> for

If I were you, I would do the same in all similar cases, but again, at this
moment I am talking about this commit only, and I am insisting on not
allowing empty commit messages for any code I maintain, without exceptions.


> r~

reply via email to

[Prev in Thread] Current Thread [Next in Thread]