[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 9/9] target/ppc: Fix vsum2sws
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 9/9] target/ppc: Fix vsum2sws |
Date: |
Tue, 7 May 2019 15:25:00 +1000 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Tue, May 07, 2019 at 10:48:11AM +1000, Anton Blanchard wrote:
> A recent cleanup changed the pre zeroing of the result from 64 bit
> to 32 bit operations:
>
> - result.u64[i] = 0;
> + result.VsrW(i) = 0;
>
> This corrupts the result.
>
> Fixes: 60594fea298d ("target/ppc: remove various HOST_WORDS_BIGENDIAN hacks
> in int_helper.c")
> Signed-off-by: Anton Blanchard <address@hidden>
Applied, thanks.
> ---
> target/ppc/int_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c
> index 111586c981..b8b3279f71 100644
> --- a/target/ppc/int_helper.c
> +++ b/target/ppc/int_helper.c
> @@ -2038,7 +2038,7 @@ void helper_vsum2sws(CPUPPCState *env, ppc_avr_t *r,
> ppc_avr_t *a, ppc_avr_t *b)
> for (i = 0; i < ARRAY_SIZE(r->u64); i++) {
> int64_t t = (int64_t)b->VsrSW(upper + i * 2);
>
> - result.VsrW(i) = 0;
> + result.VsrD(i) = 0;
> for (j = 0; j < ARRAY_SIZE(r->u64); j++) {
> t += a->VsrSW(2 * i + j);
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x, (continued)
- Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x, Anton Blanchard, 2019/05/21
- Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x, David Gibson, 2019/05/21
- Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x, Mark Cave-Ayland, 2019/05/22
- Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x, David Gibson, 2019/05/22
- Re: [Qemu-devel] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x, Mark Cave-Ayland, 2019/05/24
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x, Greg Kurz, 2019/05/22
[Qemu-devel] [PATCH 7/9] target/ppc: Fix vrlwmi and vrlwnm, Anton Blanchard, 2019/05/06
[Qemu-devel] [PATCH 8/9] target/ppc: Fix dtstsfi and dtstsfiq, Anton Blanchard, 2019/05/06
[Qemu-devel] [PATCH 9/9] target/ppc: Fix vsum2sws, Anton Blanchard, 2019/05/06
[Qemu-devel] [PATCH 6/9] target/ppc: Fix vslv and vsrv, Anton Blanchard, 2019/05/06
Re: [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Alexey Kardashevskiy, 2019/05/06
Re: [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, David Gibson, 2019/05/07
Re: [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Philippe Mathieu-Daudé, 2019/05/07
Re: [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Eric Blake, 2019/05/07