[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 22/38] target/cris: Use tcg_gen_abs_tl
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 22/38] target/cris: Use tcg_gen_abs_tl |
Date: |
Tue, 23 Apr 2019 12:09:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/20/19 9:34 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/cris/translate.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index 11b2c11174..0374718f66 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -1685,18 +1685,11 @@ static int dec_cmp_r(CPUCRISState *env, DisasContext
> *dc)
>
> static int dec_abs_r(CPUCRISState *env, DisasContext *dc)
> {
> - TCGv t0;
> -
> LOG_DIS("abs $r%u, $r%u\n",
> dc->op1, dc->op2);
> cris_cc_mask(dc, CC_MASK_NZ);
>
> - t0 = tcg_temp_new();
> - tcg_gen_sari_tl(t0, cpu_R[dc->op1], 31);
> - tcg_gen_xor_tl(cpu_R[dc->op2], cpu_R[dc->op1], t0);
> - tcg_gen_sub_tl(cpu_R[dc->op2], cpu_R[dc->op2], t0);
> - tcg_temp_free(t0);
> -
> + tcg_gen_abs_tl(cpu_R[dc->op2], cpu_R[dc->op1]);
> cris_alu(dc, CC_OP_MOVE,
> cpu_R[dc->op2], cpu_R[dc->op2], cpu_R[dc->op2], 4);
> return 2;
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [Qemu-devel] [PATCH 34/38] tcg: Do not recreate INDEX_op_neg_vec unless supported, (continued)
- [Qemu-devel] [PATCH 34/38] tcg: Do not recreate INDEX_op_neg_vec unless supported, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 37/38] tcg/aarch64: Use MVNI for expansion of dupi, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 26/38] tcg/i386: Support vector absolute value, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 31/38] target/ppc: Use vector variable shifts for VS{L, R, RA}{B, H, W, D}, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 35/38] tcg: Introduce do_op3_nofail for vector expansion, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 33/38] tcg/aarch64: Do not advertise minmax for MO_64, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 29/38] tcg/i386: Support vector comparison select value, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 38/38] tcg/aarch64: Use ORRI and BICI for vector logical operations, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 28/38] tcg: Add support for vector comparison select, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 22/38] target/cris: Use tcg_gen_abs_tl, Richard Henderson, 2019/04/20
- Re: [Qemu-devel] [PATCH 22/38] target/cris: Use tcg_gen_abs_tl,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 36/38] tcg: Expand vector minmax using cmp+cmpsel, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 20/38] tcg: Add support for vector absolute value, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 27/38] tcg/aarch64: Support vector absolute value, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 30/38] tcg/aarch64: Support vector comparison select value, Richard Henderson, 2019/04/20
- [Qemu-devel] [PATCH 32/38] target/arm: Vectorize USHL and SSHL, Richard Henderson, 2019/04/20
- Re: [Qemu-devel] [PATCH 00/38] tcg vector improvements, no-reply, 2019/04/20
- Re: [Qemu-devel] [PATCH 00/38] tcg vector improvements, David Hildenbrand, 2019/04/23