Re: [Qemu-devel] [PATCH v2] vl: set LC_CTYPE early in main() for all code

[Daniel P . Berrangé]

On Mon, Apr 15, 2019 at 10:25:03AM -0500, Eric Blake wrote:
> On 4/15/19 9:25 AM, Peter Maydell wrote:
> > On Mon, 15 Apr 2019 at 15:17, Daniel P. Berrangé <address@hidden> wrote:
> >>
> 
> > A few typo nits below...
> 
> Also:
> 
> > 
> >>
> >> +    /*
> >> +     * Ideally we would set LC_ALL, but QEMU currently isn't able to cope
> >> +     * with arbitrary localization settings. In particular there are two
> >> +     * known problems
> 
> "two known problems" but...
> 
> >> +     *
> >> +     *   - The QMP monitor needs to use the C locale rules for numeric
> >> +     *     formatting. This would need a double/int -> string formatter
> >> +     *     that is locale independant.
> > 
> > "independent"
> > 
> >> +     *
> >> +     *   - The QMP monitor needs to encode all data as UTF-8. This needs
> >> +     *     to be updated to use iconv(3) to explicitly convert the current
> >> +     *     locale's charset into utf-8
> >> +     *
> >> +     *   - Lots of codes uses is{upper,lower,alnum,...} functions, 
> >> expecting
> > 
> > "code"
> > 
> >> +     *     C locale sorting behaviour. Most QEMU usage should likely be
> >> +     *     changed to g_ascii_is{upper,lower,alnum...} to match code
> >> +     *     assumptions, without being broken by locale settnigs.
> > 
> > "settings"
> 
> ...three bullet points.

Heh, I knew I should have used "some" instead of "two" earlier when
first writing this. It was inevitable I'd think of another problem
to add :-)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|