Re: [Qemu-devel] [PATCH v2] vl: set LC_CTYPE early in main() for all code

[Eric Blake]

On 4/15/19 9:25 AM, Peter Maydell wrote:
> On Mon, 15 Apr 2019 at 15:17, Daniel P. Berrangé <address@hidden> wrote:
>>

> A few typo nits below...

Also:

> 
>>
>> +    /*
>> +     * Ideally we would set LC_ALL, but QEMU currently isn't able to cope
>> +     * with arbitrary localization settings. In particular there are two
>> +     * known problems

"two known problems" but...

>> +     *
>> +     *   - The QMP monitor needs to use the C locale rules for numeric
>> +     *     formatting. This would need a double/int -> string formatter
>> +     *     that is locale independant.
> 
> "independent"
> 
>> +     *
>> +     *   - The QMP monitor needs to encode all data as UTF-8. This needs
>> +     *     to be updated to use iconv(3) to explicitly convert the current
>> +     *     locale's charset into utf-8
>> +     *
>> +     *   - Lots of codes uses is{upper,lower,alnum,...} functions, expecting
> 
> "code"
> 
>> +     *     C locale sorting behaviour. Most QEMU usage should likely be
>> +     *     changed to g_ascii_is{upper,lower,alnum...} to match code
>> +     *     assumptions, without being broken by locale settnigs.
> 
> "settings"

...three bullet points.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature