Re: [Qemu-devel] [PATCH] target: mips: Add /* comments to fix checkpatch error

[Stefano Garzarella]

On Wed, Mar 27, 2019 at 10:38:59AM +0000, Jules Irenge wrote:
> Add /* comment  to fix checkpatch warning
> "WARNING: Block comments use a leading /* on a separate line".
> 
> Signed-off-by: Jules Irenge <address@hidden>
> ---
>  target/mips/cp0_timer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/mips/cp0_timer.c b/target/mips/cp0_timer.c
> index ffa460be25..d6c9bb8169 100644
> --- a/target/mips/cp0_timer.c
> +++ b/target/mips/cp0_timer.c
> @@ -42,8 +42,8 @@ uint32_t cpu_mips_get_random(CPUMIPSState *env)
>  
>      /* Don't return same value twice, so get another value */
>      do {
> -        /* Use a simple algorithm of Linear Congruential Generator
> -         * from ISO/IEC 9899 standard. */
> +        /* Use a simple algorithm of Linear Congruential Generator */
> +        /* from ISO/IEC 9899 standard. */

Thanks for this patch, but this is a multiline comment. Looking at
CODING_STYLE, section "7. Comment style", we should use this form:
    /*
     * like
     * this
     */

Thanks,
Stefano