Re: [Qemu-devel] [PATCH] target: mips: Add /* comments to fix checkpatch error

[Markus Armbruster]

Jules Irenge <address@hidden> writes:

> Add /* comment  to fix checkpatch warning
> "WARNING: Block comments use a leading /* on a separate line".
>
> Signed-off-by: Jules Irenge <address@hidden>
> ---
>  target/mips/cp0_timer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/mips/cp0_timer.c b/target/mips/cp0_timer.c
> index ffa460be25..d6c9bb8169 100644
> --- a/target/mips/cp0_timer.c
> +++ b/target/mips/cp0_timer.c
> @@ -42,8 +42,8 @@ uint32_t cpu_mips_get_random(CPUMIPSState *env)
>  
>      /* Don't return same value twice, so get another value */
>      do {
> -        /* Use a simple algorithm of Linear Congruential Generator
> -         * from ISO/IEC 9899 standard. */
> +        /* Use a simple algorithm of Linear Congruential Generator */
> +        /* from ISO/IEC 9899 standard. */
>          seed = 1103515245 * seed + 12345;
>          idx = (seed >> 16) % nb_rand_tlb + env->CP0_Wired;
>      } while (idx == prev_idx);

Please do

           /*
            * Use a simple algorithm of Linear Congruential Generator
            * from ISO/IEC 9899 standard.
            */

instead.