Re: [Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

[Paolo Bonzini]

On 21/03/19 13:46, Laurent Vivier wrote:
> +
> +ifneq ($(CONFIG_USER_ONLY),y)
>  #######################################################################
>  # authz-obj-y is code used by both qemu system emulation and qemu-img
>  
> @@ -21,21 +27,11 @@ block-obj-$(CONFIG_REPLICATION) += replication.o
>  
>  block-obj-m = block/

Two remarks:

1) Isn't CONFIG_USER_ONLY set to y even if tools are built?

2) Notwithstanding the answer to (1), why is this part needed at all?
The only things that have dependencies on crypto-obj-y, io-obj-y etc.
are $(SOFTMMU_SUBDIR_RULES), the tools, and the tests that you are
disabling already.  Therefore, why are they built at all for user-only
builds?

3) I don't really see the need or advantage in conditionalizing tests of
libqemuutil.a, which is built even for linux-user builds (even though
e.g. the coroutines code does not end up in the binary).  Since most of
the tests you are removing are related to the block layer, perhaps you
can add

CONFIG_BLOCK := $(call lor, $(CONFIG_SOFTMMU), $(call notempty,$(TOOLS))

and use it to conditionalize the testcases that depend on block-obj-y?

Paolo