qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets
Date: Tue, 26 Mar 2019 09:44:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 21/03/19 13:46, Laurent Vivier wrote:
> we don't need to generate the files for linux-user or for the tools
> 
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index d8dad39c5db1..609fac844637 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -261,6 +261,7 @@ trace-dtrace-root.o: trace-dtrace-root.dtrace
>  KEYCODEMAP_GEN = $(SRC_PATH)/ui/keycodemapdb/tools/keymap-gen
>  KEYCODEMAP_CSV = $(SRC_PATH)/ui/keycodemapdb/data/keymaps.csv
>  
> +ifdef CONFIG_SOFTMMU
>  KEYCODEMAP_FILES = \
>                ui/input-keymap-atset1-to-qcode.c \
>                ui/input-keymap-linux-to-qcode.c \
> @@ -295,6 +296,7 @@ ui/input-keymap-%.c: $(KEYCODEMAP_GEN) $(KEYCODEMAP_CSV) 
> $(SRC_PATH)/ui/Makefile
>  
>  $(KEYCODEMAP_GEN): .git-submodule-status
>  $(KEYCODEMAP_CSV): .git-submodule-status
> +endif

I think all you need is

if CONFIG_SOFTMMU
GENERATED_FILES += $(KEYCODEMAP_FILES)
endif

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]