Re: [Qemu-devel] [PATCH V2 3/4] tests/libqos: fix usage of bool in pci-spapr.c

[David Gibson]

On Sat, Mar 23, 2019 at 05:26:36PM +0300, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from 
> stdbool.h.
> 
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also 
> use
> TRUE and FALSE for variables that are declared as "bool" (the type from 
> <stdbool.h>).
> 
> Signed-off-by: Jafar Abdi <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Acked-by: David Gibson <address@hidden>

> ---
>  tests/libqos/pci-spapr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/libqos/pci-spapr.c b/tests/libqos/pci-spapr.c
> index 6925925..58ba27a 100644
> --- a/tests/libqos/pci-spapr.c
> +++ b/tests/libqos/pci-spapr.c
> @@ -156,7 +156,7 @@ void qpci_init_spapr(QPCIBusSPAPR *qpci, QTestState *qts,
>      assert(qts);
>  
>      /* tests cannot use spapr, needs to be fixed first */
> -    qpci->bus.has_buggy_msi = TRUE;
> +    qpci->bus.has_buggy_msi = true;
>  
>      qpci->alloc = alloc;
>  

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature