[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 2/4] tests/libqos: fix usage of bool in pci-p
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH V2 2/4] tests/libqos: fix usage of bool in pci-pc.c |
Date: |
Sun, 24 Mar 2019 20:39:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also
> use
> TRUE and FALSE for variables that are declared as "bool" (the type from
> <stdbool.h>).
>
> Signed-off-by: Jafar Abdi <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> tests/libqos/pci-pc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci-pc.c
> index 4ab16fa..407d8af 100644
> --- a/tests/libqos/pci-pc.c
> +++ b/tests/libqos/pci-pc.c
> @@ -125,7 +125,7 @@ void qpci_init_pc(QPCIBusPC *qpci, QTestState *qts,
> QGuestAllocator *alloc)
> assert(qts);
>
> /* tests can use pci-bus */
> - qpci->bus.has_buggy_msi = FALSE;
> + qpci->bus.has_buggy_msi = false;
>
> qpci->bus.pio_readb = qpci_pc_pio_readb;
> qpci->bus.pio_readw = qpci_pc_pio_readw;
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH V2 0/4] fix usage of bool, Jafar Abdi, 2019/03/23
- [Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c, Jafar Abdi, 2019/03/23
- [Qemu-devel] [PATCH V2 2/4] tests/libqos: fix usage of bool in pci-pc.c, Jafar Abdi, 2019/03/23
- [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c, Jafar Abdi, 2019/03/23
- [Qemu-devel] [PATCH V2 3/4] tests/libqos: fix usage of bool in pci-spapr.c, Jafar Abdi, 2019/03/23
- Re: [Qemu-devel] [PATCH V2 0/4] fix usage of bool, Stefan Hajnoczi, 2019/03/26
- Re: [Qemu-devel] [PATCH V2 0/4] fix usage of bool, Stefan Hajnoczi, 2019/03/26