Re: [Qemu-devel] [PATCH] mips-fulong2e: obey -vga none

[Markus Armbruster]

BALATON Zoltan <address@hidden> writes:

> On Tue, 19 Mar 2019, Paolo Bonzini wrote:
>> Do not create an ATI VGA if "-vga none" was passed on the command line.
>>
>> Cc: BALATON Zoltan <address@hidden>
>
> Thanks, I did not know about this variable. Although the real hardware
> has the GPU soldered on the mainboard it makes sense to allow it to be
> disabled in QEMU especially at this stage when Linux kernel has some
> problem with it so this is a good idea.
>
> Reviewed-by: BALATON Zoltan <address@hidden>
>
> When changing it you could also replace the -1 in pci_create with
> PCI_DEVFN(FULONG2E_ATI_SLOT, 0) to match the address the board has or
> should that be a separate patch?

Replacing these -1 in board code is generally a good idea.  I'd make it
a separate patch.