qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] mips-fulong2e: obey -vga none


From: Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH] mips-fulong2e: obey -vga none
Date: Tue, 19 Mar 2019 15:05:10 +0000

> From: Paolo Bonzini <address@hidden>
> Cc: address@hidden; BALATON Zoltan; Aleksandar Markovic; Aleksandar Rikalo; 
> Aurelien Jarno
> Subject: [PATCH] mips-fulong2e: obey -vga none
> 
> Do not create an ATI VGA if "-vga none" was passed on the command line.
> 
> Cc: BALATON Zoltan <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---

This looks like a very good point to me.

I am going to wait for comments of others.

Many thanks, Paolo!
Aleksandar

P.S. Balaton Zoltan, what is your first, and what is your last name? I know 
"Zoltan" can be both.

>  hw/mips/mips_fulong2e.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> index 9d7480ed31..05a5a823a1 100644
> --- a/hw/mips/mips_fulong2e.c
> +++ b/hw/mips/mips_fulong2e.c
> @@ -349,10 +349,12 @@ static void mips_fulong2e_init(MachineState *machine)
>                                 &smbus, &isa_bus);
> 
>      /* GPU */
> -    dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
> -    qdev_prop_set_uint32(dev, "vgamem_mb", 16);
> -    qdev_prop_set_uint16(dev, "x-device-id", 0x5159);
> -    qdev_init_nofail(dev);
> +    if (vga_interface_type != VGA_NONE) {
> +        dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
> +        qdev_prop_set_uint32(dev, "vgamem_mb", 16);
> +        qdev_prop_set_uint16(dev, "x-device-id", 0x5159);
> +        qdev_init_nofail(dev);
> +    }
> 
>      /* Populate SPD eeprom data */
>      spd_data = spd_data_generate(DDR, ram_size, &err);
> --
> 2.20.1
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]