[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v15 24/24] icount: clean up cpu_can_io before jumpin
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH v15 24/24] icount: clean up cpu_can_io before jumping to the next block |
Date: |
Mon, 18 Mar 2019 12:29:41 +0300 |
User-agent: |
StGit/0.17.1-dirty |
Most of IO instructions can be executed only at the end of the block in
icount mode. Therefore translator can set cpu_can_io flag when translating
the last instruction.
But when the blocks are chained, then this flag is not reset and may
remain set at the beginning of the next block.
This patch resets the flag before "chaining" the translation blocks.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
accel/tcg/tcg-runtime.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runtime.c
index d0d4484406..5871f5aba2 100644
--- a/accel/tcg/tcg-runtime.c
+++ b/accel/tcg/tcg-runtime.c
@@ -151,6 +151,8 @@ void *HELPER(lookup_tb_ptr)(CPUArchState *env)
target_ulong cs_base, pc;
uint32_t flags;
+ /* We are going to jump to the next block. can_do_io should be reset */
+ cpu->can_do_io = !use_icount;
tb = tb_lookup__cpu_state(cpu, &pc, &cs_base, &flags, curr_cflags());
if (tb == NULL) {
return tcg_ctx->code_gen_epilogue;
- [Qemu-devel] [PATCH v15 00/24] Fix record/replay and add reverse debugging, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 24/24] icount: clean up cpu_can_io before jumping to the next block,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH v15 23/24] replay: rename step-related variables and functions, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 22/24] replay: fix replay shutdown, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 21/24] util/qemu-timer: refactor deadline calculation for external timers, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 20/24] replay: document development rules, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 18/24] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 19/24] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 17/24] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 11/24] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 08/24] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/03/18
- [Qemu-devel] [PATCH v15 06/24] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2019/03/18