[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] ppc/pnv: Use local_err variable in pnv_chip
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] ppc/pnv: Use local_err variable in pnv_chip_power9_intc_create() |
|
Date: |
Wed, 13 Mar 2019 16:19:02 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 3/13/19 3:54 PM, Greg Kurz wrote:
> Detected by Coverity: CID 1399702
>
> Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
> ---
> hw/ppc/pnv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 8be4d4cbf785..dfb4ea5742c1 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -755,7 +755,7 @@ static void pnv_chip_power9_intc_create(PnvChip *chip,
> PowerPCCPU *cpu,
> * controller object is initialized afterwards. Hopefully, it's
> * only used at runtime.
> */
> - obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive), errp);
> + obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive),
> &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> return;
>