[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] ppc/pnv: Use local_err variable in pnv_chip
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] ppc/pnv: Use local_err variable in pnv_chip_power9_intc_create() |
Date: |
Thu, 14 Mar 2019 12:13:02 +1100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
On Wed, Mar 13, 2019 at 03:54:01PM +0100, Greg Kurz wrote:
> Detected by Coverity: CID 1399702
Series applied to ppc-for-4.0, thanks.
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> hw/ppc/pnv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 8be4d4cbf785..dfb4ea5742c1 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -755,7 +755,7 @@ static void pnv_chip_power9_intc_create(PnvChip *chip,
> PowerPCCPU *cpu,
> * controller object is initialized afterwards. Hopefully, it's
> * only used at runtime.
> */
> - obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive), errp);
> + obj = xive_tctx_create(OBJECT(cpu), XIVE_ROUTER(&chip9->xive),
> &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> return;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature