[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/9] qemu-binfmt-conf.sh: make opts -p and -c
From: |
Unai Martinez Corral |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean |
Date: |
Tue, 12 Mar 2019 22:39:18 +0100 |
2019/3/12, Eric Blake:
>
> On 3/12/19 2:51 PM, Unai Martinez-Corral wrote:
> > This patch breaks backward compatibility.
> >
>
> Is it worth a mention why we don't consider backwards-compatibility for
> this script to be very important?
'persistent' is a quite recent feature (8 monts) which seems not to be
widely know. See, e.g., the references in
https://github.com/umarcor/qus#similar-projects-blog-posts-and-other-references.
So I think that it is almost harmless.
Regarding 'credential', I don't know.
> > Both '--persistent' and '--credential' default to 'no'. Hence, '-p no'
> > or '-c no' are reduntant. Overall, accepting an argument might be
>
> redundant
>
> (Maintainer could fix up the typo without you needing to send v8, if the
> only thing I find are minor like that)
Good catch.
- [Qemu-devel] [PATCH v7 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*, (continued)
- [Qemu-devel] [PATCH v7 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 3/9] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 1/9] qemu-binfmt-conf.sh: enforce safe style consistency, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean, Unai Martinez-Corral, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12