[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh |
Date: |
Tue, 12 Mar 2019 13:28:29 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
06fcdd2f68 qemu-binfmt-conf.sh: add --test
67dcee9729 qemu-binfmt-conf.sh: add option --clear
7bedb69707 qemu-binfmt-conf.sh: generalize <CPU> to positional TARGETS
3875b6eff7 qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX
e6af40a676 qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options
1143ec15c3 qemu-binfmt-conf.sh: use the same presentation format as for qemu-*
07fe769605 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT
b5dc35e961 qemu-binfmt-conf.sh: make opts -p and -c boolean
9f57529d18 qemu-binfmt-conf.sh: enforce safe style consistency
=== OUTPUT BEGIN ===
1/9 Checking commit 9f57529d18af (qemu-binfmt-conf.sh: enforce safe style
consistency)
WARNING: line over 80 characters
#53: FILE: scripts/qemu-binfmt-conf.sh:299:
+ if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ;
then
total: 0 errors, 1 warnings, 47 lines checked
Patch 1/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/9 Checking commit b5dc35e96166 (qemu-binfmt-conf.sh: make opts -p and -c
boolean)
ERROR: line over 90 characters
#51: FILE: scripts/qemu-binfmt-conf.sh:327:
+options=$(getopt -o ds:Q:S:e:hcp -l
debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent
-- "$@")
total: 1 errors, 0 warnings, 43 lines checked
Patch 2/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/9 Checking commit 07fe76960563 (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and
QEMU_PERSISTENT)
4/9 Checking commit 1143ec15c340 (qemu-binfmt-conf.sh: use the same
presentation format as for qemu-*)
WARNING: line over 80 characters
#51: FILE: scripts/qemu-binfmt-conf.sh:179:
+-F|--qemu-suffix SUFFIX add a suffix to the default interpreter
name
ERROR: line over 90 characters
#52: FILE: scripts/qemu-binfmt-conf.sh:180:
+-p|--persistent QEMU_PERSISTENT (yes) load the interpreter and keep it
in memory; all future
ERROR: line over 90 characters
#54: FILE: scripts/qemu-binfmt-conf.sh:182:
+-c|--credential QEMU_CREDENTIAL (yes) credential and security tokens are
calculated according
ERROR: line over 90 characters
#59: FILE: scripts/qemu-binfmt-conf.sh:187:
+ systemd-binfmt.service for the given
CPU; if CPU is "ALL",
ERROR: line over 90 characters
#61: FILE: scripts/qemu-binfmt-conf.sh:189:
+-d|--debian don't write into /proc, generate
update-binfmts templates
ERROR: line over 90 characters
#86: FILE: scripts/qemu-binfmt-conf.sh:206:
+The environment variable HOST_ARCH allows to override 'uname' to generate
configuration files for a
total: 5 errors, 1 warnings, 79 lines checked
Patch 4/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/9 Checking commit e6af40a67671 (qemu-binfmt-conf.sh: remove 'qemu' prefix
from cli options)
WARNING: line over 80 characters
#36: FILE: scripts/qemu-binfmt-conf.sh:180:
+-F|--suffix SUFFIX add a suffix to the default interpreter
name
ERROR: line over 90 characters
#45: FILE: scripts/qemu-binfmt-conf.sh:333:
+options=$(getopt -o ds:Q:S:e:hcp -l
debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
total: 1 errors, 1 warnings, 38 lines checked
Patch 5/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit 3875b6eff7eb (qemu-binfmt-conf.sh: honour QEMU_PATH and/or
QEMU_SUFFIX)
WARNING: line over 80 characters
#23: FILE: scripts/qemu-binfmt-conf.sh:180:
+-F|--suffix SUFFIX QEMU_SUFFIX add a suffix to the default interpreter
name
total: 0 errors, 1 warnings, 30 lines checked
Patch 6/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/9 Checking commit 7bedb69707b1 (qemu-binfmt-conf.sh: generalize <CPU> to
positional TARGETS)
ERROR: line over 90 characters
#77: FILE: scripts/qemu-binfmt-conf.sh:199:
+TARGETS QEMU_TARGETS A single arch name or a list of them
(see all names below);
WARNING: line over 80 characters
#90: FILE: scripts/qemu-binfmt-conf.sh:211:
+-s|--systemd don't write into /proc, generate file(s)
for
ERROR: line over 90 characters
#104: FILE: scripts/qemu-binfmt-conf.sh:230:
+The environment variable HOST_ARCH allows to override 'uname' to generate
configuration files for
ERROR: line over 90 characters
#146: FILE: scripts/qemu-binfmt-conf.sh:359:
+options=$(getopt -o dsQ:S:e:hcp -l
debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@")
total: 3 errors, 1 warnings, 141 lines checked
Patch 7/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/9 Checking commit 67dcee9729cd (qemu-binfmt-conf.sh: add option --clear)
WARNING: line over 80 characters
#33: FILE: scripts/qemu-binfmt-conf.sh:200:
+ if empty, configure/clear all known
targets;
ERROR: line over 90 characters
#41: FILE: scripts/qemu-binfmt-conf.sh:209:
+-r|--clear QEMU_CLEAR (yes) remove registered interpreters for
target TARGETS;
ERROR: line over 90 characters
#84: FILE: scripts/qemu-binfmt-conf.sh:377:
+options=$(getopt -o rdsQ:S:e:hcp -l
clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent --
"$@")
total: 2 errors, 1 warnings, 85 lines checked
Patch 8/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/9 Checking commit 06fcdd2f68ce (qemu-binfmt-conf.sh: add --test)
WARNING: line over 80 characters
#20: FILE: scripts/qemu-binfmt-conf.sh:200:
+ if empty, configure/clear all known
targets.
ERROR: line over 90 characters
#28: FILE: scripts/qemu-binfmt-conf.sh:210:
+-t|--test QEMU_TEST (yes) test the setup with the provided
arguments, but do not
ERROR: line over 90 characters
#58: FILE: scripts/qemu-binfmt-conf.sh:377:
+options=$(getopt -o trdsQ:S:e:hcp -l
test,clear,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent
-- "$@")
total: 2 errors, 1 warnings, 61 lines checked
Patch 9/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v7 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*, (continued)
- [Qemu-devel] [PATCH v7 4/9] qemu-binfmt-conf.sh: use the same presentation format as for qemu-*, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 3/9] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 1/9] qemu-binfmt-conf.sh: enforce safe style consistency, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 5/9] qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options, Unai Martinez-Corral, 2019/03/12
- [Qemu-devel] [PATCH v7 2/9] qemu-binfmt-conf.sh: make opts -p and -c boolean, Unai Martinez-Corral, 2019/03/12
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh,
no-reply <=
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12
- Re: [Qemu-devel] [PATCH v7 0/9] qemu-binfmt-conf.sh, no-reply, 2019/03/12