[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU |
Date: |
Mon, 11 Mar 2019 12:50:13 +0000 |
On Mon, 11 Mar 2019 at 11:52, Aleksandar Markovic
<address@hidden> wrote:
>
> > From: Mateja Marjanovic <address@hidden>
> > Subject: [PATCH] target/mips: Fix minor bug in FPU
> >
> > Wrong type of NaN was generated by maddf and msubf insturctions
> > when the arguments were inf, zero, nan or zero, inf, nan
> > respectively.
>
> I did the applicable tests on both pre-NaN2008 and NaN2008 MIPS hardware,
> and compared results with QEMu emulations. The underlying reason for this
> patch is correct, but, as Alex also pointed out, it needs some improvements.
> However, the softfreeze being so close, I am going to amend the patch while
> creating the pull request. No respin needed. All in all:
Since this is a bug fix, there is no requirement that it goes in
before softfreeze, FWIW -- pretty much any bug fix is OK for
rc1, and a focused bugfix like this one that doesn't affect
other guest architectures would be ok in rc2 as well.
thanks
-- PMM
- [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU, Mateja Marjanovic, 2019/03/07
- Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU, Aleksandar Markovic, 2019/03/11
- Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU, Aleksandar Markovic, 2019/03/11
- Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU, Alex Bennée, 2019/03/11
- Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU, Aleksandar Markovic, 2019/03/11
- Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU, Peter Maydell, 2019/03/11
- Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU, Aleksandar Markovic, 2019/03/19
- Re: [Qemu-devel] [PATCH] target/mips: Fix minor bug in FPU, Alex Bennée, 2019/03/11