[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/8] multifd: Create new next_packet_size fie
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/8] multifd: Create new next_packet_size field |
Date: |
Fri, 8 Mar 2019 19:28:30 +0000 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
* Juan Quintela (address@hidden) wrote:
> "Dr. David Alan Gilbert" <address@hidden> wrote:
> > * Juan Quintela (address@hidden) wrote:
> >> We need to send this field when we add compression support. As we are
> >> still on x- stage, we can do this kind of changes.
> >>
> >> Signed-off-by: Juan Quintela <address@hidden>
> >
> > OK, so that kind of makes sense - in that what you want to do is read
> > the whole compressed chunk in one go.
> >
> > Consider it might be a good idea to add some spare entries here;
> > say a uint64_t dummy[4] so that if you need any more fields in the
> > future it'll be easy to add them without breaking compatibility.
>
> We have a version field, so ... we can handle it relatively gratiously,
> but I see your point.
>
> How many?
<rolls dice>
4
Now don't use them all at once!
Dave
> Later, Juan.
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK