[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/8] multifd: Create new next_packet_size fie
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/8] multifd: Create new next_packet_size field |
Date: |
Thu, 7 Mar 2019 11:01:58 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/7/19 6:28 AM, Juan Quintela wrote:
> "Dr. David Alan Gilbert" <address@hidden> wrote:
>> * Juan Quintela (address@hidden) wrote:
>>> We need to send this field when we add compression support. As we are
>>> still on x- stage, we can do this kind of changes.
>>>
>>> Signed-off-by: Juan Quintela <address@hidden>
>>
>> OK, so that kind of makes sense - in that what you want to do is read
>> the whole compressed chunk in one go.
>>
>> Consider it might be a good idea to add some spare entries here;
>> say a uint64_t dummy[4] so that if you need any more fields in the
>> future it'll be easy to add them without breaking compatibility.
>
> We have a version field, so ... we can handle it relatively gratiously,
> but I see your point.
>
> How many?
What is the current struct size? Is there a nice power-of-2 or
cache-line-size multiple to round it out to?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature