[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/9] hw/misc: mips_itu: Fix 32/64 bit issue in a
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PATCH v2 1/9] hw/misc: mips_itu: Fix 32/64 bit issue in a line involving shift operator |
Date: |
Tue, 19 Feb 2019 19:14:11 +0100 |
From: Aleksandar Markovic <address@hidden>
Fix 32/64 bit issue in a line involving shift operator. "1 << ..."
calculation of size is done as a 32-bit signed integer which may
then be unintentionally sign-extended into the 64-bit result. The
problem was discovered by Coverity (CID 1398648). Using "1ULL"
instead of "1" on the LHS of the shift fixes this problem.
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/misc/mips_itu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/mips_itu.c b/hw/misc/mips_itu.c
index 1257d8f..3afdbe6 100644
--- a/hw/misc/mips_itu.c
+++ b/hw/misc/mips_itu.c
@@ -94,7 +94,7 @@ void itc_reconfigure(MIPSITUState *tag)
if (tag->saar_present) {
address = ((*(uint64_t *) tag->saar) & 0xFFFFFFFFE000ULL) << 4;
- size = 1 << ((*(uint64_t *) tag->saar >> 1) & 0x1f);
+ size = 1ULL << ((*(uint64_t *) tag->saar >> 1) & 0x1f);
is_enabled = *(uint64_t *) tag->saar & 1;
}
--
2.7.4
- [Qemu-devel] [PATCH v2 0/9] Misc target/mips fixes and improvements, Aleksandar Markovic, 2019/02/19
- [Qemu-devel] [PATCH v2 1/9] hw/misc: mips_itu: Fix 32/64 bit issue in a line involving shift operator,
Aleksandar Markovic <=
- [Qemu-devel] [PATCH v2 4/9] tests/tcg: target/mips: Add wrappers for MSA integer compare instructions, Aleksandar Markovic, 2019/02/19
- [Qemu-devel] [PATCH v2 2/9] tests/tcg: target/mips: Correct path to headers in some test source files, Aleksandar Markovic, 2019/02/19
- [Qemu-devel] [PATCH v2 3/9] tests/tcg: target/mips: Change directory name 'bit-counting' to 'bit-count', Aleksandar Markovic, 2019/02/19
- [Qemu-devel] [PATCH v2 8/9] qemu-doc: Move section on MIPS' mipssim pseudo board, Aleksandar Markovic, 2019/02/19
- [Qemu-devel] [PATCH v2 6/9] disas: nanoMIPS: Correct comments to handlers of some DSP instructions, Aleksandar Markovic, 2019/02/19
- [Qemu-devel] [PATCH v2 9/9] qemu-doc: Add section on MIPS' Fulong 2E board, Aleksandar Markovic, 2019/02/19
- [Qemu-devel] [PATCH v2 7/9] disas: nanoMIPS: Fix a function misnomer, Aleksandar Markovic, 2019/02/19
- [Qemu-devel] [PATCH v2 5/9] tests/tcg: target/mips: Add tests for MSA integer compare instructions, Aleksandar Markovic, 2019/02/19