Re: [Qemu-devel] [PATCH 06/10] r2d: Flash memory creation is confused about size, mark FIXME

[Peter Maydell]

On Tue, 19 Feb 2019 at 17:53, Markus Armbruster <address@hidden> wrote:
>
> Peter Maydell <address@hidden> writes:
> > What would this be, and when would you use it without a
> > /* FIXME this is not what the real hardware does */ ?
>
> For a purely virtual machine such as ARM virt, perhaps?
>
> Funnily, we use IDs 0x89, 0x18, 0x00, 0x00 there.

FWIW, this is "Manufacturer: Intel" and whatever device 0x18
is for Intel. IDs 2 and 3 are used by the pflash_cfi01 code
only if we're using the bogus backward-compatibility "act
like a bad emulation of two 16-bit devices making up a 32-bit
wide device", in which case they're the ID values for the
second of the two devices. (Or it might be that the ident
values then are "manuf-id manuf-id device-id device-id",
and with the not-bogus setup they're "manuf-id device-id
unused unused".)

I'm not sure whether the chips on any of these boards
really are Intel ones :-)

thanks
-- PMM