Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   4f0444f..d55451d  master     -> master
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for 
path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) 
registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 
'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 
'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered 
for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) 
registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) 
registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for 
path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) 
registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for 
path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for 
path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for 
path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) 
registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' 
(https://github.com/cota/berkeley-softfloat-3) registered for path 
'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' 
(https://github.com/cota/berkeley-testfloat-3) registered for path 
'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) 
registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out 
'22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 
'90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 
'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 
'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 
'441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 
'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 
'51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 
'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out 
'1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 
'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 
'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 
'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out 
'60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 
'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out 
'5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out 
'6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
7200ddf FIXME vhost: add more stubs
1a1c76c .travis.yml: test that no-default-device builds do not regress
9a0a2fe xtensa-softmmu.mak: express dependencies with Kconfig
be618b0 unicore32-softmmu.mak: express dependencies with Kconfig
d9ad090 sparc64-softmmu.mak: express dependencies with Kconfig
18a4c0d sparc-softmmu.mak: express dependencies with Kconfig
f06759a sh4-softmmu.mak: express dependencies with Kconfig
3f8d9da s390x: express dependencies with Kconfig
666c38d or1k-softmmu.mak: express dependencies with Kconfig
e4cf0b1 nios2-softmmu.mak: express dependencies with Kconfig
271e994 moxie-softmmu.mak: express dependencies with Kconfig
11ac6fe microblaze-softmmu.mak: express dependencies with Kconfig
8630d29 m68k-softmmu.mak: express dependencies with Kconfig
bb5b8c4 lm32-softmmu.mak: express dependencies with Kconfig
47a8eb3 hppa-softmmu.mak: express dependencies with Kconfig
e37a3f6 cris-softmmu.mak: express dependencies with Kconfig
54b3324 alpha-softmmu.mak: express dependencies with Kconfig
8c3918f ppc: Express dependencies of the embedded machines with kconfig
3be3c9a ppc: Express dependencies of the Sam460EX machines with kconfig
19c005f ppc: Express dependencies of the Mac machines with kconfig
ebd7936 ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
72b67a6 ppc64: Express dependencies of 'pseries' and 'powernv' machines with 
kconfig
8abc3eb i386-softmmu.mak: remove all CONFIG_* except boards definitions
fcea2b4 ipmi: express dependencies with kconfig
aa72187 sd: express dependencies with kconfig
a8c95c0 ssi: express dependencies with kconfig
d977792 isa: express SuperIO dependencies with Kconfig
0541b47 tpm: express dependencies with Kconfig
4ba345d virtio: express virtio dependencies with Kconfig
bffc349 vfio: express vfio dependencies with Kconfig
905e23c hyperv: express dependencies with kconfig
ac6ba4d display: express dependencies with kconfig
c20f81c ptimer: express dependencies with Kconfig
0d7ab9a i2c: express dependencies with Kconfig
93dfb44 i386: express dependencies with Kconfig
5ce4356 isa: express dependencies with kconfig
5aeac2f scsi: express dependencies with Kconfig
3f49df6 block: fix recursion in hw/block/dataplane
2dae6c9 build: convert usb.mak to Kconfig
c41b238 build: convert sound.mak to Kconfig
d207ac7 build: convert pci.mak to Kconfig
332759d hw/pci/Makefile.objs: make pcie configurable
964747c ide: express dependencies with Kconfig
4ba9b1e kconfig: introduce CONFIG_TEST_DEVICES
857d8dd minikconfig: implement allnoconfig and defconfig modes
adbcf89 build: switch to Kconfig
4705a32 kconfig: introduce kconfig files
c261ec8 hw/display: make edid configurable
1abaa52 minikconfig: add semantic analysis
81983df minikconfig: add AST
439b9a8 minikconfig: add parser skeleton

=== OUTPUT BEGIN ===
1/51 Checking commit 439b9a844f55 (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#259: FILE: scripts/minikconf.py:220:
+                           'Expected identifier starting with "CONFIG_"', 
TOK_NONE)

WARNING: line over 80 characters
#358: FILE: scripts/minikconf.py:319:
+            raise KconfigParserError(self, 'expected "source", "config", 
identifier, '

WARNING: line over 80 characters
#384: FILE: scripts/minikconf.py:345:
+            raise KconfigParserError(self, 'expected "source", "config" or 
identifier')

ERROR: line over 90 characters
#409: FILE: scripts/minikconf.py:370:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + 
length] == '|':

WARNING: line over 80 characters
#464: FILE: scripts/minikconf.py:425:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == 
'_':

total: 1 errors, 5 warnings, 441 lines checked

Patch 1/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/51 Checking commit 81983df1c912 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:90:
+                return "config %s default %s if %s" % (self.dest, value, 
self.cond)

total: 0 errors, 1 warnings, 177 lines checked

Patch 2/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/51 Checking commit 1abaa5246a66 (minikconfig: add semantic analysis)
ERROR: line over 90 characters
#112: FILE: scripts/minikconf.py:106:
+                raise KconfigParserError('contradiction between clauses when 
setting %s' % self)

WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:218:
+            debug_print(i, "->", [str(x) for x in 
self.referenced_vars[i].outgoing])

total: 1 errors, 1 warnings, 235 lines checked

Patch 3/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/51 Checking commit c261ec829410 (hw/display: make edid configurable)
5/51 Checking commit 4705a32c99d7 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

WARNING: line over 80 characters
#1753: FILE: scripts/minikconf.py:653:
+        print ("%s: at least one argument is required" % argv[0], 
file=sys.stderr)

total: 0 errors, 2 warnings, 1354 lines checked

Patch 5/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/51 Checking commit adbcf89201ae (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#504: 
deleted file mode 100644

total: 0 errors, 1 warnings, 346 lines checked

Patch 6/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/51 Checking commit 857d8ddaa222 (minikconfig: implement allnoconfig and 
defconfig modes)
8/51 Checking commit 4ba9b1e19593 (kconfig: introduce CONFIG_TEST_DEVICES)
9/51 Checking commit 964747cd173c (ide: express dependencies with Kconfig)
10/51 Checking commit 332759d72e52 (hw/pci/Makefile.objs: make pcie 
configurable)
11/51 Checking commit d207ac71cd9b (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#145: 
deleted file mode 100644

total: 0 errors, 1 warnings, 490 lines checked

Patch 11/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/51 Checking commit c41b2385df3d (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 12/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/51 Checking commit 2dae6c9a738c (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158: 
deleted file mode 100644

total: 0 errors, 1 warnings, 165 lines checked

Patch 13/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/51 Checking commit 3f49df6864b2 (block: fix recursion in hw/block/dataplane)
15/51 Checking commit 5aeac2faf1bf (scsi: express dependencies with Kconfig)
16/51 Checking commit 5ce435607c6b (isa: express dependencies with kconfig)
17/51 Checking commit 93dfb44abb9b (i386: express dependencies with Kconfig)
18/51 Checking commit 0d7ab9a7842d (i2c: express dependencies with Kconfig)
19/51 Checking commit c20f81c35457 (ptimer: express dependencies with Kconfig)
20/51 Checking commit ac6ba4de7df3 (display: express dependencies with kconfig)
21/51 Checking commit 905e23c6c3a2 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
deleted file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Patch 21/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/51 Checking commit bffc349b2c0f (vfio: express vfio dependencies with 
Kconfig)
23/51 Checking commit 4ba345db983e (virtio: express virtio dependencies with 
Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
deleted file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 23/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/51 Checking commit 0541b479283c (tpm: express dependencies with Kconfig)
25/51 Checking commit d9777923da08 (isa: express SuperIO dependencies with 
Kconfig)
26/51 Checking commit a8c95c0992f8 (ssi: express dependencies with kconfig)
27/51 Checking commit aa72187aaf99 (sd: express dependencies with kconfig)
28/51 Checking commit fcea2b455a6b (ipmi: express dependencies with kconfig)
29/51 Checking commit 8abc3ebf15b4 (i386-softmmu.mak: remove all CONFIG_* 
except boards definitions)
30/51 Checking commit 72b67a6b72a6 (ppc64: Express dependencies of 'pseries' 
and 'powernv' machines with kconfig)
31/51 Checking commit ebd7936f6328 (ppc: Express dependencies of the 'prep' and 
'40p' machines with kconfig)
32/51 Checking commit 19c005fbac41 (ppc: Express dependencies of the Mac 
machines with kconfig)
33/51 Checking commit 3be3c9af3716 (ppc: Express dependencies of the Sam460EX 
machines with kconfig)
34/51 Checking commit 8c3918f63317 (ppc: Express dependencies of the embedded 
machines with kconfig)
35/51 Checking commit 54b33245e960 (alpha-softmmu.mak: express dependencies 
with Kconfig)
36/51 Checking commit e37a3f607d8e (cris-softmmu.mak: express dependencies with 
Kconfig)
37/51 Checking commit 47a8eb3fca4a (hppa-softmmu.mak: express dependencies with 
Kconfig)
38/51 Checking commit bb5b8c48ed9f (lm32-softmmu.mak: express dependencies with 
Kconfig)
39/51 Checking commit 8630d296858c (m68k-softmmu.mak: express dependencies with 
Kconfig)
40/51 Checking commit 11ac6fe9d46c (microblaze-softmmu.mak: express 
dependencies with Kconfig)
41/51 Checking commit 271e994332e0 (moxie-softmmu.mak: express dependencies 
with Kconfig)
42/51 Checking commit e4cf0b120e83 (nios2-softmmu.mak: express dependencies 
with Kconfig)
43/51 Checking commit 666c38d4f18d (or1k-softmmu.mak: express dependencies with 
Kconfig)
44/51 Checking commit 3f8d9dac4fb7 (s390x: express dependencies with Kconfig)
45/51 Checking commit f06759a86b89 (sh4-softmmu.mak: express dependencies with 
Kconfig)
46/51 Checking commit 18a4c0d9850d (sparc-softmmu.mak: express dependencies 
with Kconfig)
47/51 Checking commit d9ad090d4a13 (sparc64-softmmu.mak: express dependencies 
with Kconfig)
48/51 Checking commit be618b0b435d (unicore32-softmmu.mak: express dependencies 
with Kconfig)
49/51 Checking commit 9a0a2fe4903c (xtensa-softmmu.mak: express dependencies 
with Kconfig)
50/51 Checking commit 1a1c76cc663f (.travis.yml: test that no-default-device 
builds do not regress)
51/51 Checking commit 7200ddfa38df (FIXME vhost: add more stubs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden