Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7200ddfa38 FIXME vhost: add more stubs
1a1c76cc66 .travis.yml: test that no-default-device builds do not regress
9a0a2fe490 xtensa-softmmu.mak: express dependencies with Kconfig
be618b0b43 unicore32-softmmu.mak: express dependencies with Kconfig
d9ad090d4a sparc64-softmmu.mak: express dependencies with Kconfig
18a4c0d985 sparc-softmmu.mak: express dependencies with Kconfig
f06759a86b sh4-softmmu.mak: express dependencies with Kconfig
3f8d9dac4f s390x: express dependencies with Kconfig
666c38d4f1 or1k-softmmu.mak: express dependencies with Kconfig
e4cf0b120e nios2-softmmu.mak: express dependencies with Kconfig
271e994332 moxie-softmmu.mak: express dependencies with Kconfig
11ac6fe9d4 microblaze-softmmu.mak: express dependencies with Kconfig
8630d29685 m68k-softmmu.mak: express dependencies with Kconfig
bb5b8c48ed lm32-softmmu.mak: express dependencies with Kconfig
47a8eb3fca hppa-softmmu.mak: express dependencies with Kconfig
e37a3f607d cris-softmmu.mak: express dependencies with Kconfig
54b33245e9 alpha-softmmu.mak: express dependencies with Kconfig
8c3918f633 ppc: Express dependencies of the embedded machines with kconfig
3be3c9af37 ppc: Express dependencies of the Sam460EX machines with kconfig
19c005fbac ppc: Express dependencies of the Mac machines with kconfig
ebd7936f63 ppc: Express dependencies of the 'prep' and '40p' machines with 
kconfig
72b67a6b72 ppc64: Express dependencies of 'pseries' and 'powernv' machines with 
kconfig
8abc3ebf15 i386-softmmu.mak: remove all CONFIG_* except boards definitions
fcea2b455a ipmi: express dependencies with kconfig
aa72187aaf sd: express dependencies with kconfig
a8c95c0992 ssi: express dependencies with kconfig
d9777923da isa: express SuperIO dependencies with Kconfig
0541b47928 tpm: express dependencies with Kconfig
4ba345db98 virtio: express virtio dependencies with Kconfig
bffc349b2c vfio: express vfio dependencies with Kconfig
905e23c6c3 hyperv: express dependencies with kconfig
ac6ba4de7d display: express dependencies with kconfig
c20f81c354 ptimer: express dependencies with Kconfig
0d7ab9a784 i2c: express dependencies with Kconfig
93dfb44abb i386: express dependencies with Kconfig
5ce435607c isa: express dependencies with kconfig
5aeac2faf1 scsi: express dependencies with Kconfig
3f49df6864 block: fix recursion in hw/block/dataplane
2dae6c9a73 build: convert usb.mak to Kconfig
c41b2385df build: convert sound.mak to Kconfig
d207ac71cd build: convert pci.mak to Kconfig
332759d72e hw/pci/Makefile.objs: make pcie configurable
964747cd17 ide: express dependencies with Kconfig
4ba9b1e195 kconfig: introduce CONFIG_TEST_DEVICES
857d8ddaa2 minikconfig: implement allnoconfig and defconfig modes
adbcf89201 build: switch to Kconfig
4705a32c99 kconfig: introduce kconfig files
c261ec8294 hw/display: make edid configurable
1abaa5246a minikconfig: add semantic analysis
81983df1c9 minikconfig: add AST
439b9a844f minikconfig: add parser skeleton

=== OUTPUT BEGIN ===
1/51 Checking commit 439b9a844f55 (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#259: FILE: scripts/minikconf.py:220:
+                           'Expected identifier starting with "CONFIG_"', 
TOK_NONE)

WARNING: line over 80 characters
#358: FILE: scripts/minikconf.py:319:
+            raise KconfigParserError(self, 'expected "source", "config", 
identifier, '

WARNING: line over 80 characters
#384: FILE: scripts/minikconf.py:345:
+            raise KconfigParserError(self, 'expected "source", "config" or 
identifier')

ERROR: line over 90 characters
#409: FILE: scripts/minikconf.py:370:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + 
length] == '|':

WARNING: line over 80 characters
#464: FILE: scripts/minikconf.py:425:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == 
'_':

total: 1 errors, 5 warnings, 441 lines checked

Patch 1/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/51 Checking commit 81983df1c912 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:90:
+                return "config %s default %s if %s" % (self.dest, value, 
self.cond)

total: 0 errors, 1 warnings, 177 lines checked

Patch 2/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/51 Checking commit 1abaa5246a66 (minikconfig: add semantic analysis)
ERROR: line over 90 characters
#112: FILE: scripts/minikconf.py:106:
+                raise KconfigParserError('contradiction between clauses when 
setting %s' % self)

WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:218:
+            debug_print(i, "->", [str(x) for x in 
self.referenced_vars[i].outgoing])

total: 1 errors, 1 warnings, 235 lines checked

Patch 3/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/51 Checking commit c261ec829410 (hw/display: make edid configurable)
5/51 Checking commit 4705a32c99d7 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

WARNING: line over 80 characters
#1753: FILE: scripts/minikconf.py:653:
+        print ("%s: at least one argument is required" % argv[0], 
file=sys.stderr)

total: 0 errors, 2 warnings, 1354 lines checked

Patch 5/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/51 Checking commit adbcf89201ae (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#504: 
deleted file mode 100644

total: 0 errors, 1 warnings, 346 lines checked

Patch 6/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/51 Checking commit 857d8ddaa222 (minikconfig: implement allnoconfig and 
defconfig modes)
8/51 Checking commit 4ba9b1e19593 (kconfig: introduce CONFIG_TEST_DEVICES)
9/51 Checking commit 964747cd173c (ide: express dependencies with Kconfig)
10/51 Checking commit 332759d72e52 (hw/pci/Makefile.objs: make pcie 
configurable)
11/51 Checking commit d207ac71cd9b (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#145: 
deleted file mode 100644

total: 0 errors, 1 warnings, 490 lines checked

Patch 11/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/51 Checking commit c41b2385df3d (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 12/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/51 Checking commit 2dae6c9a738c (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158: 
deleted file mode 100644

total: 0 errors, 1 warnings, 165 lines checked

Patch 13/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/51 Checking commit 3f49df6864b2 (block: fix recursion in hw/block/dataplane)
15/51 Checking commit 5aeac2faf1bf (scsi: express dependencies with Kconfig)
16/51 Checking commit 5ce435607c6b (isa: express dependencies with kconfig)
17/51 Checking commit 93dfb44abb9b (i386: express dependencies with Kconfig)
18/51 Checking commit 0d7ab9a7842d (i2c: express dependencies with Kconfig)
19/51 Checking commit c20f81c35457 (ptimer: express dependencies with Kconfig)
20/51 Checking commit ac6ba4de7df3 (display: express dependencies with kconfig)
21/51 Checking commit 905e23c6c3a2 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
deleted file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Patch 21/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/51 Checking commit bffc349b2c0f (vfio: express vfio dependencies with 
Kconfig)
23/51 Checking commit 4ba345db983e (virtio: express virtio dependencies with 
Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
deleted file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 23/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/51 Checking commit 0541b479283c (tpm: express dependencies with Kconfig)
25/51 Checking commit d9777923da08 (isa: express SuperIO dependencies with 
Kconfig)
26/51 Checking commit a8c95c0992f8 (ssi: express dependencies with kconfig)
27/51 Checking commit aa72187aaf99 (sd: express dependencies with kconfig)
28/51 Checking commit fcea2b455a6b (ipmi: express dependencies with kconfig)
29/51 Checking commit 8abc3ebf15b4 (i386-softmmu.mak: remove all CONFIG_* 
except boards definitions)
30/51 Checking commit 72b67a6b72a6 (ppc64: Express dependencies of 'pseries' 
and 'powernv' machines with kconfig)
31/51 Checking commit ebd7936f6328 (ppc: Express dependencies of the 'prep' and 
'40p' machines with kconfig)
32/51 Checking commit 19c005fbac41 (ppc: Express dependencies of the Mac 
machines with kconfig)
33/51 Checking commit 3be3c9af3716 (ppc: Express dependencies of the Sam460EX 
machines with kconfig)
34/51 Checking commit 8c3918f63317 (ppc: Express dependencies of the embedded 
machines with kconfig)
35/51 Checking commit 54b33245e960 (alpha-softmmu.mak: express dependencies 
with Kconfig)
36/51 Checking commit e37a3f607d8e (cris-softmmu.mak: express dependencies with 
Kconfig)
37/51 Checking commit 47a8eb3fca4a (hppa-softmmu.mak: express dependencies with 
Kconfig)
38/51 Checking commit bb5b8c48ed9f (lm32-softmmu.mak: express dependencies with 
Kconfig)
39/51 Checking commit 8630d296858c (m68k-softmmu.mak: express dependencies with 
Kconfig)
40/51 Checking commit 11ac6fe9d46c (microblaze-softmmu.mak: express 
dependencies with Kconfig)
41/51 Checking commit 271e994332e0 (moxie-softmmu.mak: express dependencies 
with Kconfig)
42/51 Checking commit e4cf0b120e83 (nios2-softmmu.mak: express dependencies 
with Kconfig)
43/51 Checking commit 666c38d4f18d (or1k-softmmu.mak: express dependencies with 
Kconfig)
44/51 Checking commit 3f8d9dac4fb7 (s390x: express dependencies with Kconfig)
45/51 Checking commit f06759a86b89 (sh4-softmmu.mak: express dependencies with 
Kconfig)
46/51 Checking commit 18a4c0d9850d (sparc-softmmu.mak: express dependencies 
with Kconfig)
47/51 Checking commit d9ad090d4a13 (sparc64-softmmu.mak: express dependencies 
with Kconfig)
48/51 Checking commit be618b0b435d (unicore32-softmmu.mak: express dependencies 
with Kconfig)
49/51 Checking commit 9a0a2fe4903c (xtensa-softmmu.mak: express dependencies 
with Kconfig)
50/51 Checking commit 1a1c76cc663f (.travis.yml: test that no-default-device 
builds do not regress)
51/51 Checking commit 7200ddfa38df (FIXME vhost: add more stubs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden