[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/9] check-venv: use recorded Python version
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 4/9] check-venv: use recorded Python version |
Date: |
Thu, 17 Jan 2019 18:17:38 -0200 |
From: Cleber Rosa <address@hidden>
The current approach works fine, but it runs Python on every make
command (even if it's not related to the venv usage).
This is just an optimization, and not a change of behavior.
Signed-off-by: Cleber Rosa <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
tests/Makefile.include | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index f403a6571d..f8d4399293 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -958,8 +958,7 @@ TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results
# information please refer to "avocado --help".
AVOCADO_SHOW=none
-PYTHON3 = $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_info >= (3,
0) else 0)')
-ifeq ($(PYTHON3), 1)
+ifneq ($(findstring v2,"v$(PYTHON_VERSION)"),v2)
$(TESTS_VENV_DIR): $(TESTS_VENV_REQ)
$(call quiet-command, \
$(PYTHON) -m venv --system-site-packages $@, \
--
2.18.0.rc1.1.g3f1ff2140
- [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 1/9] scripts/device-crash-test: Remove known crashes, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 2/9] scripts: Remove unused python imports, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 3/9] configure: keep track of Python version, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 5/9] Travis CI: make specified Python versions usable on jobs, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 4/9] check-venv: use recorded Python version,
Eduardo Habkost <=
- [Qemu-devel] [PULL 6/9] check-help: visual and content improvements, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 7/9] Acceptance tests: add Linux initrd checking test, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 9/9] scripts/replay-dump.py: fix utf-8 mangling, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 8/9] qemu.py: Fix error message when qemu dies from signal, Eduardo Habkost, 2019/01/17
- Re: [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17, Peter Maydell, 2019/01/18