[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/9] Acceptance tests: add Linux initrd checking test
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 7/9] Acceptance tests: add Linux initrd checking test |
Date: |
Thu, 17 Jan 2019 18:17:41 -0200 |
From: Wainer dos Santos Moschetta <address@hidden>
QEMU used to exits with a not accurate error message when
an initrd > 2GiB was passed. That was fixed on patch:
commit f3839fda5771596152b75dd1e1a6d050e6e6e380
Author: Li Zhijian <address@hidden>
Date: Thu Sep 13 18:07:13 2018 +0800
change get_image_size return type to int64_t
This change adds a regression test for that fix. It starts
QEMU with a 2GiB dummy initrd, and checks that it evaluates the
file size correctly and prints an accurate message.
Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
Reviewed-by: Caio Carrara <address@hidden>
Reviewed-by: Cleber Rosa <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
tests/acceptance/linux_initrd.py | 48 ++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
create mode 100644 tests/acceptance/linux_initrd.py
diff --git a/tests/acceptance/linux_initrd.py b/tests/acceptance/linux_initrd.py
new file mode 100644
index 0000000000..737355c2ef
--- /dev/null
+++ b/tests/acceptance/linux_initrd.py
@@ -0,0 +1,48 @@
+# Linux initrd acceptance test.
+#
+# Copyright (c) 2018 Red Hat, Inc.
+#
+# Author:
+# Wainer dos Santos Moschetta <address@hidden>
+#
+# This work is licensed under the terms of the GNU GPL, version 2 or
+# later. See the COPYING file in the top-level directory.
+
+import tempfile
+from avocado.utils.process import run
+
+from avocado_qemu import Test
+
+
+class LinuxInitrd(Test):
+ """
+ Checks QEMU evaluates correctly the initrd file passed as -initrd option.
+
+ :avocado: enable
+ :avocado: tags=x86_64
+ """
+
+ timeout = 60
+
+ def test_with_2gib_file_should_exit_error_msg(self):
+ """
+ Pretends to boot QEMU with an initrd file with size of 2GiB
+ and expect it exits with error message.
+ """
+ kernel_url = ('https://mirrors.kernel.org/fedora/releases/28/'
+ 'Everything/x86_64/os/images/pxeboot/vmlinuz')
+ kernel_hash = '238e083e114c48200f80d889f7e32eeb2793e02a'
+ kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
+ max_size = 2 * (1024 ** 3) - 1
+
+ with tempfile.NamedTemporaryFile() as initrd:
+ initrd.seek(max_size)
+ initrd.write(b'\0')
+ initrd.flush()
+ cmd = "%s -kernel %s -initrd %s" % (self.qemu_bin, kernel_path,
+ initrd.name)
+ res = run(cmd, ignore_status=True)
+ self.assertEqual(res.exit_status, 1)
+ expected_msg = r'.*initrd is too large.*max: \d+, need %s.*' % (
+ max_size + 1)
+ self.assertRegex(res.stderr_text, expected_msg)
--
2.18.0.rc1.1.g3f1ff2140
- [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 1/9] scripts/device-crash-test: Remove known crashes, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 2/9] scripts: Remove unused python imports, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 3/9] configure: keep track of Python version, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 5/9] Travis CI: make specified Python versions usable on jobs, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 4/9] check-venv: use recorded Python version, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 6/9] check-help: visual and content improvements, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 7/9] Acceptance tests: add Linux initrd checking test,
Eduardo Habkost <=
- [Qemu-devel] [PULL 9/9] scripts/replay-dump.py: fix utf-8 mangling, Eduardo Habkost, 2019/01/17
- [Qemu-devel] [PULL 8/9] qemu.py: Fix error message when qemu dies from signal, Eduardo Habkost, 2019/01/17
- Re: [Qemu-devel] [PULL 0/9] Python queue, 2019-01-17, Peter Maydell, 2019/01/18