[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/35] memory: avoid unnecessary coalesced_io_del ope
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 09/35] memory: avoid unnecessary coalesced_io_del operations |
Date: |
Tue, 18 Dec 2018 00:16:34 +0100 |
Store whether the FlatRange has had any coalesced I/O ranges applied,
and if not avoid calling coalesced_io_del. This is useful in preparation
for the next patch, which will call coalesced_io_del when rendering
memory regions.
Signed-off-by: Paolo Bonzini <address@hidden>
---
memory.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/memory.c b/memory.c
index 119b6e46d5..072769aa06 100644
--- a/memory.c
+++ b/memory.c
@@ -217,6 +217,7 @@ struct FlatRange {
bool romd_mode;
bool readonly;
bool nonvolatile;
+ bool has_coalesced_range;
};
#define FOR_EACH_FLAT_RANGE(var, view) \
@@ -650,6 +651,7 @@ static void render_memory_region(FlatView *view,
fr.romd_mode = mr->romd_mode;
fr.readonly = readonly;
fr.nonvolatile = nonvolatile;
+ fr.has_coalesced_range = false;
/* Render the region itself into any gaps left by the current view. */
for (i = 0; i < view->nr && int128_nz(remain); ++i) {
@@ -852,6 +854,10 @@ static void address_space_update_ioeventfds(AddressSpace
*as)
static void flat_range_coalesced_io_del(FlatRange *fr, AddressSpace *as)
{
+ if (!fr->has_coalesced_range) {
+ return;
+ }
+
MEMORY_LISTENER_UPDATE_REGION(fr, as, Reverse, coalesced_io_del,
int128_get64(fr->addr.start),
int128_get64(fr->addr.size));
@@ -863,6 +869,11 @@ static void flat_range_coalesced_io_add(FlatRange *fr,
AddressSpace *as)
CoalescedMemoryRange *cmr;
AddrRange tmp;
+ if (QTAILQ_EMPTY(&mr->coalesced)) {
+ return;
+ }
+
+ fr->has_coalesced_range = true;
QTAILQ_FOREACH(cmr, &mr->coalesced, link) {
tmp = addrrange_shift(cmr->addr,
int128_sub(fr->addr.start,
--
2.20.1
- [Qemu-devel] [PULL 00/35] Misc patches for 2018-12-18, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 01/35] accel: Improve selection of the default accelerator, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 02/35] vhost-user-bridge: fix "unknown type name" compilation error, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 03/35] checkpatch: fix premature exit when no input or --mailback, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 05/35] checkpatch: improve handling of multiple patches or files, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 04/35] checkpatch: check Signed-off-by in --mailback mode, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 06/35] checkpatch: colorize output to terminal, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 07/35] pam: wrap MemoryRegion initialization in a transaction, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 08/35] memory: extract flat_range_coalesced_io_{del, add}, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 09/35] memory: avoid unnecessary coalesced_io_del operations,
Paolo Bonzini <=
- [Qemu-devel] [PULL 10/35] memory: update coalesced_range on transaction_commit, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 11/35] hax: Support for Linux hosts, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 13/35] block/iscsi: take iscsilun->mutex in iscsi_timed_check_events(), Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 12/35] block/iscsi: drop unused IscsiAIOCB->buf field, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 15/35] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 16/35] esp-pci: Fix status register write erase control, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 14/35] block/iscsi: fix ioctl cancel use-after-free, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 17/35] scsi: esp: Defer command completion until previous interrupts have been handled, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 18/35] build-sys: don't include windows.h, osdep.h does it, Paolo Bonzini, 2018/12/17
- [Qemu-devel] [PULL 19/35] build-sys: move windows defines in osdep.h header, Paolo Bonzini, 2018/12/17