qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 04/35] checkpatch: check Signed-off-by in --mailback


From: Paolo Bonzini
Subject: [Qemu-devel] [PULL 04/35] checkpatch: check Signed-off-by in --mailback mode
Date: Tue, 18 Dec 2018 00:16:29 +0100

Pull the test before the anticipated exits from the process sub.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 scripts/checkpatch.pl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c503122911..d20bc58578 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2816,6 +2816,10 @@ sub process {
                }
        }
 
+       if ($is_patch && $chk_signoff && $signoff == 0) {
+               ERROR("Missing Signed-off-by: line(s)\n");
+       }
+
        # If we have no input at all, then there is nothing to report on
        # so just keep quiet.
        if ($#rawlines == -1) {
@@ -2837,9 +2841,6 @@ sub process {
        if (!$is_patch) {
                ERROR("Does not appear to be a unified-diff format patch\n");
        }
-       if ($is_patch && $chk_signoff && $signoff == 0) {
-               ERROR("Missing Signed-off-by: line(s)\n");
-       }
 
        print report_dump();
        if ($summary && !($clean == 1 && $quiet == 1)) {
-- 
2.20.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]