[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 67/73] sparc: convert to cpu_has_work_with_io
From: |
Mark Cave-Ayland |
Subject: |
Re: [Qemu-devel] [PATCH v5 67/73] sparc: convert to cpu_has_work_with_iothread_lock |
Date: |
Mon, 17 Dec 2018 12:58:58 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 13/12/2018 05:04, Emilio G. Cota wrote:
> Soon we will call cpu_has_work without the BQL.
>
> Cc: Mark Cave-Ayland <address@hidden>
> Cc: Artyom Tarasenko <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/sparc/cpu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
> index 88427283c1..54bffc1a6c 100644
> --- a/target/sparc/cpu.c
> +++ b/target/sparc/cpu.c
> @@ -709,6 +709,8 @@ static bool sparc_cpu_has_work(CPUState *cs)
> SPARCCPU *cpu = SPARC_CPU(cs);
> CPUSPARCState *env = &cpu->env;
>
> + g_assert(qemu_mutex_iothread_locked());
> +
> return (cpu_interrupt_request(cs) & CPU_INTERRUPT_HARD) &&
> cpu_interrupts_enabled(env);
> }
> @@ -870,7 +872,7 @@ static void sparc_cpu_class_init(ObjectClass *oc, void
> *data)
>
> cc->class_by_name = sparc_cpu_class_by_name;
> cc->parse_features = sparc_cpu_parse_features;
> - cc->has_work = sparc_cpu_has_work;
> + cc->has_work_with_iothread_lock = sparc_cpu_has_work;
> cc->do_interrupt = sparc_cpu_do_interrupt;
> cc->cpu_exec_interrupt = sparc_cpu_exec_interrupt;
> cc->dump_state = sparc_cpu_dump_state;
Acked-by: Mark Cave-Ayland <address@hidden>
ATB,
Mark.
- [Qemu-devel] [PATCH v5 55/73] sparc: convert to cpu_interrupt_request, (continued)
- [Qemu-devel] [PATCH v5 55/73] sparc: convert to cpu_interrupt_request, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 51/73] nios: convert to cpu_interrupt_request, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 69/73] cpu: rename all_cpu_threads_idle to qemu_tcg_rr_all_cpu_threads_idle, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 71/73] cpus-common: release BQL earlier in run_on_cpu, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 73/73] cputlb: queue async flush jobs without the BQL, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 17/73] arm: convert to cpu_halted, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 57/73] unicore32: convert to cpu_interrupt_request, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 61/73] cpu: call .cpu_has_work with the CPU lock held, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 67/73] sparc: convert to cpu_has_work_with_iothread_lock, Emilio G. Cota, 2018/12/13
- Re: [Qemu-devel] [PATCH v5 67/73] sparc: convert to cpu_has_work_with_iothread_lock,
Mark Cave-Ayland <=
- [Qemu-devel] [PATCH v5 38/73] arm: convert to cpu_interrupt_request, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 47/73] hppa: convert to cpu_interrupt_request, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 62/73] cpu: introduce cpu_has_work_with_iothread_lock, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 59/73] accel/tcg: convert to cpu_interrupt_request, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 64/73] mips: convert to cpu_has_work_with_iothread_lock, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 25/73] s390x: convert to cpu_halted, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 44/73] ppc: convert to cpu_interrupt_request, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 68/73] xtensa: convert to cpu_has_work_with_iothread_lock, Emilio G. Cota, 2018/12/13
- [Qemu-devel] [PATCH v5 52/73] s390x: convert to cpu_interrupt_request, Emilio G. Cota, 2018/12/13