[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 7/8] vfio/pci: Remove PCIe Link Status emulation
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PATCH v5 7/8] vfio/pci: Remove PCIe Link Status emulation |
Date: |
Wed, 12 Dec 2018 12:39:56 -0700 |
User-agent: |
StGit/0.19-dirty |
Now that the downstream port will virtually negotiate itself to the
link status of the downstream device, we can remove this emulation.
It's not clear that it was every terribly useful anyway.
Tested-by: Geoffrey McRae <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>
---
hw/vfio/pci.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 74f9a46b4be0..c0cb1ec28908 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1901,12 +1901,6 @@ static int vfio_setup_pcie_cap(VFIOPCIDevice *vdev, int
pos, uint8_t size,
QEMU_PCI_EXP_LNKCAP_MLS(QEMU_PCI_EXP_LNK_2_5GT),
~0);
vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKCTL, 0, ~0);
}
-
- /* Mark the Link Status bits as emulated to allow virtual negotiation
*/
- vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKSTA,
- pci_get_word(vdev->pdev.config + pos +
- PCI_EXP_LNKSTA),
- PCI_EXP_LNKCAP_MLW | PCI_EXP_LNKCAP_SLS);
}
/*
- [Qemu-devel] [PATCH v5 0/8] pcie: Enhanced link speed and width support, Alex Williamson, 2018/12/12
- [Qemu-devel] [PATCH v5 1/8] pcie: Create enums for link speed and width, Alex Williamson, 2018/12/12
- [Qemu-devel] [PATCH v5 2/8] pci: Sync PCIe downstream port LNKSTA on read, Alex Williamson, 2018/12/12
- [Qemu-devel] [PATCH v5 3/8] qapi: Define PCIe link speed and width properties, Alex Williamson, 2018/12/12
- [Qemu-devel] [PATCH v5 4/8] pcie: Add link speed and width fields to PCIESlot, Alex Williamson, 2018/12/12
- [Qemu-devel] [PATCH v5 5/8] pcie: Fill PCIESlot link fields to support higher speeds and widths, Alex Williamson, 2018/12/12
- [Qemu-devel] [PATCH v5 7/8] vfio/pci: Remove PCIe Link Status emulation,
Alex Williamson <=
- [Qemu-devel] [PATCH v5 6/8] pcie: Allow generic PCIe root port to specify link speed and width, Alex Williamson, 2018/12/12
[Qemu-devel] [PATCH v5 8/8] pcie: Fast PCIe root ports for new machines, Alex Williamson, 2018/12/12