[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h" |
|
Date: |
Mon, 10 Dec 2018 16:53:20 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/10/18 4:00 PM, Laszlo Ersek wrote:
> On 12/07/18 17:51, Philippe Mathieu-Daudé wrote:
>> All the consumers of "smbios_ipmi.h" are located in hw/smbios/.
>
> I tried to verify this statement by grepping the tree for
> "smbios_ipmi.h". There were zero hits. Please use the more precise
> pathname "hw/smbios/ipmi.h". (I can't suggest just "ipmi.h", because
> that isn't unique.)
I did not notice I used the post-patch pathname, thanks.
>
> With this update:
>
> Reviewed-by: Laszlo Ersek <address@hidden>
>
> Thanks,
> Laszlo
- [Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace, Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 1/4] tests: Remove unused include, Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h", Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 3/4] hw/smbios: Remove "smbios_ipmi.h", Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 4/4] hw/smbios: Move to the hw/firmware/ namespace, Philippe Mathieu-Daudé, 2018/12/07
- Re: [Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace, Michael S. Tsirkin, 2018/12/07