[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] tests: Remove unused include
|
From: |
Laszlo Ersek |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/4] tests: Remove unused include |
|
Date: |
Mon, 10 Dec 2018 15:55:16 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 12/07/18 17:51, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/acpi-utils.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/acpi-utils.c b/tests/acpi-utils.c
> index 41dc1ea9b4..297af55d39 100644
> --- a/tests/acpi-utils.c
> +++ b/tests/acpi-utils.c
> @@ -15,7 +15,6 @@
> #include "qemu/osdep.h"
> #include <glib/gstdio.h>
> #include "qemu-common.h"
> -#include "hw/smbios/smbios.h"
> #include "qemu/bitmap.h"
> #include "acpi-utils.h"
> #include "boot-sector.h"
>
Opinions vary whether empty commit message bodies are good style or not.
Personally I prefer to put at least one sentence in there, even if it
only repeats the subject line. Up to subsystem maintainers to decide I
guess.
With the commit message updated, or not:
Reviewed-by: Laszlo Ersek <address@hidden>