Re: [Qemu-devel] [PATCH 15/71] tests/libqos: introduce virtio_start_device

[Thomas Huth]

On 2018-12-03 16:32, Paolo Bonzini wrote:
> From: Emanuele Giuseppe Esposito <address@hidden>
> 
> This function is intended to group all the qvirtio_* functions that
> start the qvirtio devices.
> Applied in all tests using this combination of functions.
> 
> Signed-off-by: Emanuele Giuseppe Esposito <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  tests/libqos/virtio.c    |  7 +++++++
>  tests/libqos/virtio.h    |  1 +
>  tests/vhost-user-test.c  |  4 +---
>  tests/virtio-9p-test.c   |  4 +---
>  tests/virtio-blk-test.c  | 10 +++-------
>  tests/virtio-net-test.c  |  4 +---
>  tests/virtio-scsi-test.c |  4 +---
>  7 files changed, 15 insertions(+), 19 deletions(-)
[...]
> diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
> index 04c6087..f97c158 100644
> --- a/tests/virtio-blk-test.c
> +++ b/tests/virtio-blk-test.c
> @@ -116,10 +116,7 @@ static QVirtioPCIDevice *virtio_blk_pci_init(QPCIBus 
> *bus, int slot)
>      g_assert_cmphex(dev->pdev->devfn, ==, ((slot << 3) | PCI_FN));
>  
>      qvirtio_pci_device_enable(dev);
> -    qvirtio_reset(&dev->vdev);
> -    qvirtio_set_acknowledge(&dev->vdev);
> -    qvirtio_set_driver(&dev->vdev);
> -
> +    qvirtio_start_device(&dev->vdev);
>      return dev;
>  }
>  
> @@ -333,6 +330,7 @@ static void pci_indirect(void)
>      qvirtio_set_features(&dev->vdev, features);
>  
>      vqpci = (QVirtQueuePCI *)qvirtqueue_setup(&dev->vdev, qs->alloc, 0);
> +
>      qvirtio_set_driver_ok(&dev->vdev);

Unnecessary white-space change. Apart from that nit:

Reviewed-by: Thomas Huth <address@hidden>