Re: [Qemu-devel] [PATCH v6 03/37] ppc/xive: introduce the XiveNotifier interface

[Cédric Le Goater]

On 12/7/18 3:07 AM, David Gibson wrote:
> On Thu, Dec 06, 2018 at 07:17:47AM +0100, Cédric Le Goater wrote:
>> On 12/6/18 4:25 AM, David Gibson wrote:
>>> On Thu, Dec 06, 2018 at 12:22:17AM +0100, Cédric Le Goater wrote:
>>>> The XiveNotifier offers a simple interface, between the XiveSource
>>>> object and the main interrupt controller of the machine. It will
>>>> forward event notifications to the XIVE Interrupt Virtualization
>>>> Routing Engine (IVRE).
>>>>
>>>> Signed-off-by: Cédric Le Goater <address@hidden>
>>>> ---
>>>>  include/hw/ppc/xive.h | 23 +++++++++++++++++++++++
>>>>  hw/intc/xive.c        | 25 +++++++++++++++++++++++++
>>>>  2 files changed, 48 insertions(+)
>>>>
>>>> diff --git a/include/hw/ppc/xive.h b/include/hw/ppc/xive.h
>>>> index 7cebc32eba4c..6770cffec67d 100644
>>>> --- a/include/hw/ppc/xive.h
>>>> +++ b/include/hw/ppc/xive.h
>>>> @@ -142,6 +142,27 @@
>>>>  
>>>>  #include "hw/qdev-core.h"
>>>>  
>>>> +/*
>>>> + * XIVE Fabric (Interface between Source and Router)
>>>> + */
>>>> +
>>>> +typedef struct XiveNotifier {
>>>> +    Object parent;
>>>> +} XiveNotifier;
>>>> +
>>>> +#define TYPE_XIVE_NOTIFIER "xive-fabric"
>>>
>>> I'm applying this, but changing the string here from "xive-fabric" to
>>> "xive-notifier".
>>
>> Ah yes. My sed command missed that.
> 
> So, I've now applied patches 1-5.  I think we've agreed to a change in
> patch 6 which will require tweaks to a bunch further down the series,

yes.

> so I think the rest will need a v7.

Yes.

Here's my TODO list : 

- some asserts and comments
- introduce a helper to get the CAM line of a ring
- rework the physical CAM line setting.
- introduce a "block" property in XiveENDSource
- remove chip_id id from XiveRouter
- may be modify XiveRouter to be a QOM interface


The hcalls are the big remaining part to review before adding the 
XIVE-only machine.

I think I will move up in the patchset the TCG "dual" machine because 
it does not need much more changes and the XICS machine is not impacted.

KVM will come after.
 

Thanks,

C.