[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 07/13] fpu: introduce hardfloat
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v6 07/13] fpu: introduce hardfloat |
Date: |
Wed, 5 Dec 2018 11:08:52 -0500 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Wed, Dec 05, 2018 at 06:07:44 -0500, Programmingkid wrote:
>
> > On Dec 4, 2018, at 2:10 PM, address@hidden wrote:
> >
> > Emilio G. Cota <address@hidden> writes:
> >
> >> On Tue, Dec 04, 2018 at 13:52:16 +0000, Alex Benn?e wrote:
> >>>> We could always
> >>>>
> >>>> #ifdef __FAST_MATH__
> >>>> #error "Silliness like this will get you nowhere"
> >>>> #endif
> >>>
> >>> Emilio, are you happy to add that guard with a suitable pithy comment?
> >>
> >> Isn't it better to just disable hardfloat then?
> >>
> >> --- a/fpu/softfloat.c
> >> +++ b/fpu/softfloat.c
> >> @@ -220,7 +220,7 @@ GEN_INPUT_FLUSH3(float64_input_flush3, float64)
> >> * the use of hardfloat, since hardfloat relies on the inexact flag being
> >> * already set.
> >> */
> >> -#if defined(TARGET_PPC)
> >> +#if defined(TARGET_PPC) || defined(__FAST_MATH__)
> >> # define QEMU_NO_HARDFLOAT 1
> >> # define QEMU_SOFTFLOAT_ATTR QEMU_FLATTEN
> >> #else
>
> Why can't PowerPC also benefit from a hardfloat? It uses IEEE754 also.
Please see this message:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04974.html
Thanks,
E.